This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
STIJ-195: Added pre-commit hook support. #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daften
suggested changes
Dec 1, 2017
postinstall.sh
Outdated
| cp -R ./node_modules/jquery ./public/styleguide/vendor/jquery; | ||
| cp -R ./node_modules/chosen-js ./public/styleguide/vendor/chosen-js; | ||
|
|
||
| cp ./scripts/pre-commit ./.git/hooks/pre-commit |
There was a problem hiding this comment.
I'd prefer something more clear for the git-hooks e.g. a .git-hooks folder which is also hidden on the filesystem by default.
There was a problem hiding this comment.
Use symlink instead of copy.
No support for windows users?
scripts/pre-commit
Outdated
| git stash -q --keep-index | ||
|
|
||
| # Test prospective commit | ||
| gulp validate; |
There was a problem hiding this comment.
I'd prefer something that uses the package manager as wrapper to have uniformity. E.g. npm pre-commit. For PHP projects we could use composer pre-commit.
meirege
changed the title
meirege
changed the title
Jeroen005
approved these changes
Dec 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a pre-commit hook integration to automatically test things like JS and SASS validation.
Motivation and Context
This might reduce errors in the production code.
How Has This Been Tested?
Did a local commit test.
Screenshots (if appropriate):
Types of changes
Checklist: