From d9005a60a08c5de7b84501f629eb5fb916f86f33 Mon Sep 17 00:00:00 2001 From: amiralirahimii Date: Sun, 1 Sep 2024 09:43:26 +0330 Subject: [PATCH 1/3] feat: create transaction-service-tests file --- .../Services/DomainService/TransactionServiceTests.cs | 6 ++++++ test/UnitTest1.cs | 9 --------- 2 files changed, 6 insertions(+), 9 deletions(-) create mode 100644 test/Application.UnitTests/Services/DomainService/TransactionServiceTests.cs delete mode 100644 test/UnitTest1.cs diff --git a/test/Application.UnitTests/Services/DomainService/TransactionServiceTests.cs b/test/Application.UnitTests/Services/DomainService/TransactionServiceTests.cs new file mode 100644 index 0000000..ec8854f --- /dev/null +++ b/test/Application.UnitTests/Services/DomainService/TransactionServiceTests.cs @@ -0,0 +1,6 @@ +namespace test.Application.UnitTests.Services.DomainService; + +public class TransactionServiceTests +{ + +} \ No newline at end of file diff --git a/test/UnitTest1.cs b/test/UnitTest1.cs deleted file mode 100644 index 63cf04d..0000000 --- a/test/UnitTest1.cs +++ /dev/null @@ -1,9 +0,0 @@ -namespace test; - -public class UnitTest1 -{ - [Fact] - public void Test1() - { - } -} \ No newline at end of file From 7859a989a445ba2dc09bd59343b4fc14b8e42d5e Mon Sep 17 00:00:00 2001 From: amiralirahimii Date: Sun, 1 Sep 2024 11:14:49 +0330 Subject: [PATCH 2/3] fix: move the throwable block to try and catch --- .../Services/DomainService/TransactionService.cs | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/Application/Services/DomainService/TransactionService.cs b/src/Application/Services/DomainService/TransactionService.cs index 9e1e714..a3c5a76 100644 --- a/src/Application/Services/DomainService/TransactionService.cs +++ b/src/Application/Services/DomainService/TransactionService.cs @@ -22,14 +22,13 @@ public TransactionService(ITransactionRepository transactionRepository, IFileRea public async Task AddTransactionsFromCsvAsync(string filePath) { - var transactionCsvModels = _fileReaderService.ReadFromFile(filePath); - - var transactions = transactionCsvModels - .Select(csvModel => csvModel.ToTransaction()) - .ToList(); - try { + var transactionCsvModels = _fileReaderService.ReadFromFile(filePath); + var transactions = transactionCsvModels + .Select(csvModel => csvModel.ToTransaction()) + .ToList(); + var existingTransactionsIds = await _transactionRepository.GetAllIdsAsync(); var newTransactions = transactions.Where(t => !existingTransactionsIds.Contains(t.TransactionId)).ToList(); From cb3bc461d28bbf78daa794fa426df0fc6ccc36b5 Mon Sep 17 00:00:00 2001 From: amiralirahimii Date: Sun, 1 Sep 2024 11:15:16 +0330 Subject: [PATCH 3/3] test: add transaction-service tests --- .../DomainService/TransactionServiceTests.cs | 255 +++++++++++++++++- 1 file changed, 254 insertions(+), 1 deletion(-) diff --git a/test/Application.UnitTests/Services/DomainService/TransactionServiceTests.cs b/test/Application.UnitTests/Services/DomainService/TransactionServiceTests.cs index ec8854f..3e274be 100644 --- a/test/Application.UnitTests/Services/DomainService/TransactionServiceTests.cs +++ b/test/Application.UnitTests/Services/DomainService/TransactionServiceTests.cs @@ -1,6 +1,259 @@ -namespace test.Application.UnitTests.Services.DomainService; +using System.Globalization; +using Application.DTOs.Transaction; +using Application.Interfaces; +using Application.Interfaces.Repositories; +using Application.Mappers; +using Application.Services.DomainService; +using Domain.Entities; +using NSubstitute; +using NSubstitute.ExceptionExtensions; + +namespace test.Application.UnitTests.Services.DomainService; public class TransactionServiceTests { + private readonly ITransactionRepository _transactionRepository; + private readonly IFileReaderService _fileReaderService; + private readonly TransactionService _transactionService; + + public TransactionServiceTests() + { + _transactionRepository = Substitute.For(); + _fileReaderService = Substitute.For(); + _transactionService = new TransactionService(_transactionRepository, _fileReaderService); + } + + [Fact] + public async Task AddTransactionsFromCsvAsync_ShouldReturnOk_WhenTransactionsAreAddedSuccessfully() + { + // Arrange + var filePath = "test.csv"; + var transactionCsvModels = new List + { + new() { TransactionID = 1, SourceAcount = 101, DestiantionAccount = 102, Amount = 100, Date = new DateTime(1399, 04, 15, new PersianCalendar()), Type = "کارت به کارت" }, + new() { TransactionID = 2, SourceAcount = 101, DestiantionAccount = 103, Amount = 200, Date = new DateTime(1399, 04, 30, new PersianCalendar()), Type = "ساتنا" } + }; + // Expect these dates to be converted to Gregorian: + var expectedFirstDate = new DateTime(2020, 7, 5); // 1399/04/15 in Gregorian Calendar + var expectedSecondDate = new DateTime(2020, 7, 20); // 1399/04/30 in Gregorian Calendar + + var transactions = transactionCsvModels.Select(csvModel => csvModel.ToTransaction()).ToList(); + var existingTransactionIds = new List { 3 }; + + _fileReaderService.ReadFromFile(filePath).Returns(transactionCsvModels); + _transactionRepository.GetAllIdsAsync().Returns(existingTransactionIds); + _transactionRepository.CreateBulkAsync(Arg.Any>()).Returns(Task.CompletedTask); + + // Act + var result = await _transactionService.AddTransactionsFromCsvAsync(filePath); + + // Assert + Assert.True(result.Succeed); + + // Verifying if the dates were converted correctly + await _transactionRepository.Received(1).CreateBulkAsync(Arg.Is>(x => + x.Count == transactionCsvModels.Count && + x[0].Date == expectedFirstDate && // Ensure the first date was converted correctly + x[1].Date == expectedSecondDate // Ensure the second date was converted correctly + )); + } + + [Fact] + public async Task AddTransactionsFromCsvAsync_ShouldOnlyAddNewTransactions_WhenSomeTransactionsAlreadyExist() + { + // Arrange + var filePath = "test.csv"; + var transactionCsvModels = new List + { + new() { TransactionID = 1, SourceAcount = 101, DestiantionAccount = 102, Amount = 100, Date = new DateTime(1399, 04, 29, new PersianCalendar()), Type = "کارت به کارت" }, + new() { TransactionID = 2, SourceAcount = 101, DestiantionAccount = 103, Amount = 200, Date = new DateTime(1399, 04, 15, new PersianCalendar()), Type = "ساتنا" }, + new() { TransactionID = 3, SourceAcount = 104, DestiantionAccount = 105, Amount = 300, Date = new DateTime(1399, 04, 17, new PersianCalendar()), Type = "ساتنا"} + }; + + var transactions = transactionCsvModels.Select(csvModel => csvModel.ToTransaction()).ToList(); + + // Let's say TransactionID = 3 already exists in the database. + var existingTransactionIds = new List { 3 }; + + _fileReaderService.ReadFromFile(filePath).Returns(transactionCsvModels); + _transactionRepository.GetAllIdsAsync().Returns(existingTransactionIds); + _transactionRepository.CreateBulkAsync(Arg.Any>()).Returns(Task.CompletedTask); + + // Act + var result = await _transactionService.AddTransactionsFromCsvAsync(filePath); + + // Assert + Assert.True(result.Succeed); + + // Only the new transactions (TransactionID = 1 and TransactionID = 2) should be added. + await _transactionRepository.Received(1).CreateBulkAsync(Arg.Is>(x => + x.Count == 2 && + x.Any(t => t.TransactionId == 1) && + x.Any(t => t.TransactionId == 2) && + x.All(t => t.TransactionId != 3) + )); + } + + + [Fact] + public async Task AddTransactionsFromCsvAsync_ShouldReturnFail_WhenExceptionIsThrown() + { + // Arrange + var filePath = "test.csv"; + var exceptionMessage = "An error occurred while reading the file."; + + _fileReaderService + .ReadFromFile(filePath) + .Throws(new Exception(exceptionMessage)); + + // Act + var result = await _transactionService.AddTransactionsFromCsvAsync(filePath); + + // Assert + Assert.False(result.Succeed); + Assert.Equal($"An error occurred: {exceptionMessage}", result.Message); + } + + [Fact] + public async Task GetAllTransactionsAsync_ShouldReturnAllTransactions() + { + // Arrange + var transactions = new List + { + new() { TransactionId = 1, SourceAccountId = 101, DestinationAccountId = 102, Amount = 100, Date = DateTime.UtcNow, Type = "کارت به کارت" }, + new() { TransactionId = 2, SourceAccountId = 101, DestinationAccountId = 103, Amount = 200, Date = DateTime.UtcNow, Type = "ساتنا" } + }; + + _transactionRepository.GetAllTransactions().Returns(transactions); + + // Act + var result = await _transactionService.GetAllTransactionsAsync(); + + // Assert + Assert.True(result.Succeed); + Assert.Equal(transactions, result.Value); + } + + [Fact] + public async Task GetAllTransactionsAsync_ShouldReturnFailResult_WhenExceptionIsThrown() + { + // Arrange + var exceptionMessage = "Database connection failed."; + _transactionRepository.GetAllTransactions().Throws(new Exception(exceptionMessage)); + + // Act + var result = await _transactionService.GetAllTransactionsAsync(); + + // Assert + Assert.False(result.Succeed); + Assert.Null(result.Value); + Assert.Equal($"An error occurred: {exceptionMessage}", result.Message); + } + + [Fact] + public async Task GetAllTransactionsAsync_ShouldReturnEmptyList_WhenNoTransactionsAreFound() + { + // Arrange + var transactions = new List(); + _transactionRepository.GetAllTransactions().Returns(Task.FromResult(transactions)); + + // Act + var result = await _transactionService.GetAllTransactionsAsync(); + + // Assert + Assert.True(result.Succeed); + Assert.Empty(result.Value!); + } + + [Fact] + public async Task GetTransactionsByAccountIdAsync_ShouldReturnOkResult_WhenTransactionsAreRetrievedAndGroupedSuccessfully() + { + // Arrange + long accountId = 101; + var transactionsSourceAccount = new List + { + new Transaction { TransactionId = 1, SourceAccountId = 101, DestinationAccountId = 102, Amount = 100, Date = new DateTime(2023, 7, 5), Type = "کارت به کارت" }, + new Transaction { TransactionId = 2, SourceAccountId = 101, DestinationAccountId = 103, Amount = 200, Date = new DateTime(2023, 7, 6), Type = "ساتنا" } + }; + + var transactionsDestinationAccount = new List + { + new Transaction { TransactionId = 3, SourceAccountId = 104, DestinationAccountId = 101, Amount = 300, Date = new DateTime(2023, 7, 7), Type = "ساتنا" }, + new Transaction { TransactionId = 4, SourceAccountId = 105, DestinationAccountId = 101, Amount = 400, Date = new DateTime(2023, 7, 8), Type = "کارت به کارت" } + }; + + _transactionRepository.GetBySourceAccountId(accountId).Returns(transactionsSourceAccount); + _transactionRepository.GetByDestinationAccountId(accountId).Returns(transactionsDestinationAccount); + + // Act + var result = await _transactionService.GetTransactionsByAccountIdAsync(accountId); + + // Assert + Assert.True(result.Succeed); + Assert.Equal(4, result.Value!.Count); + } + + [Fact] + public async Task GetTransactionsByAccountIdAsync_ShouldReturnOkResult_WhenThereAreMultipleTransactionsBetweenTwoAccounts() + { + // Arrange + long accountId = 101; + var transactionsSourceAccount = new List + { + new Transaction { TransactionId = 1, SourceAccountId = 101, DestinationAccountId = 102, Amount = 100, Date = new DateTime(2023, 7, 5), Type = "کارت به کارت" }, + new Transaction { TransactionId = 2, SourceAccountId = 101, DestinationAccountId = 102, Amount = 200, Date = new DateTime(2023, 7, 6), Type = "ساتنا" } + }; + + var transactionsDestinationAccount = new List + { + new Transaction { TransactionId = 3, SourceAccountId = 104, DestinationAccountId = 101, Amount = 300, Date = new DateTime(2023, 7, 7), Type = "ساتنا" }, + new Transaction { TransactionId = 4, SourceAccountId = 102, DestinationAccountId = 101, Amount = 400, Date = new DateTime(2023, 7, 8), Type = "کارت به کارت" } + }; + + _transactionRepository.GetBySourceAccountId(accountId).Returns(transactionsSourceAccount); + _transactionRepository.GetByDestinationAccountId(accountId).Returns(transactionsDestinationAccount); + + // Act + var result = await _transactionService.GetTransactionsByAccountIdAsync(accountId); + + // Assert + Assert.True(result.Succeed); + Assert.Equal(4, result.Value!.SelectMany(x => x.TransactionWithSources).Count()); + Assert.Equal(2, result.Value!.Count); + } + + [Fact] + public async Task GetTransactionsByAccountIdAsync_ShouldReturnEmptyList_WhenNoTransactionsAreFound() + { + // Arrange + long accountId = 101; + _transactionRepository.GetBySourceAccountId(accountId).Returns(new List()); + _transactionRepository.GetByDestinationAccountId(accountId).Returns(new List()); + + // Act + var result = await _transactionService.GetTransactionsByAccountIdAsync(accountId); + + // Assert + Assert.True(result.Succeed); + Assert.Empty(result.Value!); + } + + [Fact] + public async Task GetTransactionsByAccountIdAsync_ShouldReturnFailResult_WhenExceptionIsThrown() + { + // Arrange + long accountId = 101; + var exceptionMessage = "Database error"; + _transactionRepository.GetBySourceAccountId(accountId).Throws(new Exception(exceptionMessage)); + + // Act + var result = await _transactionService.GetTransactionsByAccountIdAsync(accountId); + + // Assert + Assert.False(result.Succeed); + Assert.Null(result.Value); + Assert.Equal($"An error occurred: {exceptionMessage}", result.Message); + } + } \ No newline at end of file