Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix partial update column name sensitive issue #55430

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luohaha
Copy link
Contributor

@luohaha luohaha commented Jan 24, 2025

Why I'm doing:

Fix partial update column name sensitive issue.

E.g:
table:

CREATE TABLE `test` (
  `id` bigint(20) NOT NULL COMMENT "",
  `name` varchar(16) NULL DEFAULT "" COMMENT "",
  `city` varchar(16) NULL DEFAULT "" COMMENT "",
  `age` varchar(24) NULL DEFAULT "" COMMENT ""
) ENGINE=OLAP
PRIMARY KEY(`id`)
DISTRIBUTED BY HASH(`id`) BUCKETS 1
PROPERTIES (
"replication_num" = "1"
); 

partial update:

curl --location-trusted -u root: -T tt.csv -XPUT -H label:stream_load_1 -H "partial_update:true" -H "columns:ID,name" -H "timeout:86400" -H "max_filter_ratio:0.1" http://172.26.80.4:8030/api/testdb/test2/_stream_load

Use columns:ID,name instead of columns:id,name. It will lead to:

"Message": "key column id not in partial update columns",

What I'm doing:

Fix it

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

Signed-off-by: luohaha <18810541851@163.com>
@luohaha luohaha requested a review from a team as a code owner January 24, 2025 09:56
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 3 / 3 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/load/Load.java 3 3 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant