Skip to content

Commit

Permalink
feat(argo-controller): parameterize argo workflows resource names (#466)
Browse files Browse the repository at this point in the history
* feat(argo-controller): parameterize argo workflows role bindings & clsuter role names

* style: add extra line at bottom of file

* feat: update appVersion

* feat: remove default value for namespaceAdminsRoleBindingName
  • Loading branch information
MichaelPatsula committed Jul 18, 2024
1 parent 36f8e0b commit c1110e0
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion stable/argo-controller/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.0.10
version: 0.0.11

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
3 changes: 3 additions & 0 deletions stable/argo-controller/templates/deployment-workflows.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ spec:
imagePullPolicy: {{ .Values.image.pullPolicy }}
args:
- workflows
- -- namespace-admins-role-binding-name={{ required "workflows.args.namespaceAdminsRoleBindingName is required" .Values.workflows.args.namespaceAdminsRoleBindingName }}
- -- user-interface-cluster-role-name={{ required "workflows.args.userInterfaceClusterRoleName is required" .Values.workflows.args.userInterfaceClusterRoleName }}
- -- argo-workflows-cluster-role-name={{ required "workflows.args.argoWorkflowsClusterRoleName is required" .Values.workflows.args.argoWorkflowsClusterRoleName }}
env:
{{- if .Values.storageAccount.existingSecret }}
- name: ARGO_SECRET_NAME
Expand Down
6 changes: 6 additions & 0 deletions stable/argo-controller/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,9 @@ serviceAccount:
# The name of the service account to use.
# If not set and create is true, a name is generated using the fullname template
name: ""

workflows:
args:
namespaceAdminsRoleBindingName:
userInterfaceClusterRoleName:
argoWorkflowsClusterRoleName:

0 comments on commit c1110e0

Please sign in to comment.