Rule LC0032 should not be raised when codeunit is used in itself

StefanMaron · Nov 20, 2023 · e38c7ad · e38c7ad
1 parent 24b5192
commit e38c7ad
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/Design/Rule0032ClearCodeunitSingleInstance.cs b/Design/Rule0032ClearCodeunitSingleInstance.cs
@@ -46,11 +46,13 @@ private void ClearAllCodeunit(OperationAnalysisContext ctx)
             if (!SemanticFacts.IsSameName(operation.TargetMethod.Name, "ClearAll")) return;
 
             IEnumerable<ISymbol> localVariables = ((IMethodSymbol)ctx.ContainingSymbol.OriginalDefinition).LocalVariables
-                                                            .Where(var => var.OriginalDefinition.GetTypeSymbol().GetNavTypeKindSafe() == NavTypeKind.Codeunit);
+                                                            .Where(var => var.OriginalDefinition.GetTypeSymbol().GetNavTypeKindSafe() == NavTypeKind.Codeunit)
+                                                            .Where(var => var.OriginalDefinition.GetTypeSymbol().OriginalDefinition != ctx.ContainingSymbol.GetContainingObjectTypeSymbol().OriginalDefinition);
             IEnumerable<ISymbol> globalVariables = ctx.ContainingSymbol.GetContainingObjectTypeSymbol()
                                                             .GetMembers()
                                                             .Where(members => members.Kind == SymbolKind.GlobalVariable)
-                                                            .Where(var => var.OriginalDefinition.GetTypeSymbol().GetNavTypeKindSafe() == NavTypeKind.Codeunit);
+                                                            .Where(var => var.OriginalDefinition.GetTypeSymbol().GetNavTypeKindSafe() == NavTypeKind.Codeunit)
+                                                            .Where(var => var.OriginalDefinition.GetTypeSymbol().OriginalDefinition != ctx.ContainingSymbol.GetContainingObjectTypeSymbol().OriginalDefinition);
 
             if (HasSingleInstanceCodeunitWithGlobalVars(localVariables, out ISymbol codeunit) || HasSingleInstanceCodeunitWithGlobalVars(globalVariables, out codeunit))
                 ctx.ReportDiagnostic(Diagnostic.Create(DiagnosticDescriptors.Rule0032ClearCodeunitSingleInstance, ctx.Operation.Syntax.GetLocation(), new Object[] { codeunit.Name, codeunit.GetTypeSymbol().Name }));