Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 3 african sky culture #631

Closed
wants to merge 6 commits into from
Closed

Added 3 african sky culture #631

wants to merge 6 commits into from

Conversation

alex-w
Copy link
Member

@alex-w alex-w commented Feb 17, 2019

Description

Added 3 African sky cultures:

  • Zulu
  • Xhosa
  • Khoikhoi and San

Add sky cultures was created by Suki Lock for the South African Astronomical Observatory, based on information compiled by Auke Slotegraaf.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

  • Operating system: Ubuntu Linux 18.04
  • Graphics Card: * nVidia GeForce GTX 550 Ti/nvidia 390.87

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@alex-w alex-w requested a review from gzotti February 19, 2019 03:10
@alex-w alex-w self-assigned this Mar 1, 2019
@alex-w alex-w added this to the 0.19.0 milestone Mar 1, 2019
@gzotti
Copy link
Member

gzotti commented Mar 1, 2019

Welcome additions, in principle. However, the descriptions leave much to deserve. The skycultures may be targeted to South Africans, but we should think globally. Many (if not most) people outside Africa know that these people "live in Africa". But where? Explanations start here! General introduction about the respective groups, maybe a map (Africa with colored area should be OK) and no clear references given. Did Auke Slotegraaf write a book, is/was he ethnologer, astronomer, missionary, surveyor, railway builder, hunter, adventurer? In which decade? Any quotable information or contact addresses possible?

star_names.fab: Names in English? Why not the own names? (all 3 cultures)

Xhosa: isiLimela (Pleiades) "First Sighting" in morning or evening skies?

Khoikhoi&San: The constellation artwork with painted stars in no way matches real stars.

We are about to introduce classification labels. This should be labelled "incomplete" IMHO, but is barely acceptable.

@alex-w alex-w modified the milestones: 0.19.0, 0.19.1 Mar 16, 2019
@alex-w alex-w removed this from the 0.19.1 milestone Jun 11, 2019
@bobmeisterr
Copy link

Is there any chance I could have a look at these 3 skycultures? I'd really appreciate it if I could! Thanks :).

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the has conflicts The pull request has conflicts label Nov 15, 2020
@alex-w alex-w marked this pull request as draft November 15, 2020 14:36
@alex-w alex-w changed the title WIP: Added 3 african sky culture Added 3 african sky culture Nov 16, 2020
@github-actions github-actions bot removed the has conflicts The pull request has conflicts label Sep 12, 2021
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the has conflicts The pull request has conflicts label Sep 13, 2021
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@alex-w alex-w closed this Sep 23, 2021
@alex-w alex-w deleted the african-sky-cultures branch September 23, 2021 17:03
@alex-w alex-w added the purpose: cultural astronomy Issues, pull requests and proposals with cultural astronomy purposes label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has conflicts The pull request has conflicts purpose: cultural astronomy Issues, pull requests and proposals with cultural astronomy purposes
Development

Successfully merging this pull request may close these issues.

3 participants