Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/design-system #218

Merged
merged 26 commits into from
Dec 17, 2024
Merged

feat/design-system #218

merged 26 commits into from
Dec 17, 2024

Conversation

nathanjhood
Copy link
Member

What kind of change does this PR introduce?

  • fixed use of old C runtime on MinGW
  • fixed exact pixel size of panels for HP1, HP2, HP4, VCA
  • added assertions for the above

@nathanjhood
Merge pull request #214 from StoneyDSP/production
8cad167 
merge production
@nathanjhood
edit 'dep/vcpkg-registry/ports/rack-sdk/2.5.2/portfile.cmake' - use o…
b232046 
…bsolete C runtime for MinGW builds

Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
edit 'include/StoneyVCV/HP4.hpp' - added missing doxygen comments
9bc65e9 
Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
edit 'include/StoneyVCV/plugin.hpp' - added missing doxygen comments
a0d74c3 
Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
edit 'docs/Doxyfile' - add JAVADOC_BANNER and set to true
a1d0c98 
Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
edit 'test/StoneyVCV/HP1.cpp' - updated variable names
3d51318 
Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
edit '{include,src}/StoneyVCV/HP1.{cpp,hpp}' - add all missing declar…
af82710 
…ations, new var names

Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
edit '{include,src,test}/StoneyVCV/HP2.{cpp,hpp}' - add all missing d…
6e92917 
…eclarations, new var names

Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
edit '{include,src,test}/StoneyVCV/HP4.{cpp,hpp}' - add all missing d…
b59e757 
…eclarations, new var names

Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
edit '{include,src,test}/StoneyVCV/VCA.{cpp,hpp}' - add all missing d…
4974169 
…eclarations, new var names

Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
edit '{include,src,test}/StoneyVCV/LFO.{cpp,hpp}' - add all missing d…
e78f6ed 
…eclarations, new var names

Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
edit '{src,test}/StoneyVCV/HP1.cpp - add all missing declarations, ne…
240ddc8 
…w var names

Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
edit '{include,src,test}/StoneyVCV/plugin.{cpp,hpp}' - add all missin…
e8bd3d1 
…g declarations, new var names

Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
edit '[HP1 files]' - fixed size to exact pixels, added assertion
0358ecc 
Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
edit '[HP2 files]' - fixed size to exact pixels, added assertion
a37c2fe 
Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
edit '[HP4 files]' - fixed size to exact pixels, added assertion
50f9a01 
Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
edit 'Makefile' - better Debug mode handling
df46043 
Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
edit '.vscode/launch.json' - added platform-specific Rack launcher
10397dd 
Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
edit '{include,src}/plugin.{cpp,hpp}' - added rules for module size
1e165a7 
Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
edit 'plugin.json' - deactivate VCA for now
63e5942 
Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
edit '[VCA files]' - fixed size to exact pixels, added assertion
445e73d 
Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
edit 'include/StoneyVCV/HP4.hpp' - fixed enum names
964418f 
Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
edit 'include/plugin.hpp' - fix initializer for test spec struct
c384222 
Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
edit '.github/workflows/*-latest.yml' - install Rack2Free on all systems
9dacf84 
Signed-off-by: StoneyDSP <nathanjhood@googlemail.com>
@nathanjhood
Merge pull request #215 from StoneyDSP/feat/design-system
c38c70f 
fix/msvc-crt
@nathanjhood
Merge pull request #217 from StoneyDSP/development
580e90c 
feat/design-system
@nathanjhood nathanjhood added build system Changes or improvements to the project build system dependecies Changes or improvements to project dependencies and management module Related to a new or existing VCV Rack 2 module design system Changes to the component library, design system, or global panel code labels Dec 17, 2024
@nathanjhood nathanjhood self-assigned this Dec 17, 2024
This was linked to issues Dec 17, 2024
TODO: Roadmap to baseline #69
Open
TODO 3: Build system #164
Open
TODO 4: Design system #168
Open
TODO 5: Modules #169
Open
TODO 1: Deps #147
Open
@nathanjhood nathanjhood merged commit ad170a0 into production Dec 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nathanjhood nathanjhood

Labels
build system Changes or improvements to the project build system dependecies Changes or improvements to project dependencies and management design system Changes to the component library, design system, or global panel code module Related to a new or existing VCV Rack 2 module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TODO 5: Modules TODO 4: Design system TODO 3: Build system TODO 1: Deps TODO: Roadmap to baseline
1 participant
@nathanjhood