Fix: edit reviews presignedUrls

Strong-Potato · Jan 28, 2024 · f1c2389 · f1c2389
1 parent a5ed4a0
commit f1c2389
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 22 deletions.
diff --git a/src/App.tsx b/src/App.tsx
@@ -1,5 +1,5 @@
 import {QueryClient, QueryClientProvider} from '@tanstack/react-query';
-import {Suspense, useEffect} from 'react';
+import {Suspense} from 'react';
 import {CookiesProvider} from 'react-cookie';
 import {DndProvider} from 'react-dnd';
 import {HTML5Backend} from 'react-dnd-html5-backend';
@@ -24,11 +24,6 @@ function App() {
     '카카오톡으로 친구와 가족들을 여행에 초대해보세요',
     '요즘 인기 있는 장소를 검색해보세요',
   ];
-
-  useEffect(() => {
-    document.body.style.removeProperty('overflow');
-  });
-
   return (
     <Suspense
       fallback={

diff --git a/src/components/Detail/BottomFixedBtn/BottomFixedBtn.tsx b/src/components/Detail/BottomFixedBtn/BottomFixedBtn.tsx
@@ -27,6 +27,7 @@ function BottomFixedBtn({onOpen}: BottomFixedBtnProps) {
       navigate('/auth/login');
     },
   };
+
   const showNotLoginModal = () => {
     setIsModalOpen(true);
     setModalContent({...notLoginContent});

diff --git a/src/components/MyReview/EditReviewBottomSlide/EditReviewBottomSlide.tsx b/src/components/MyReview/EditReviewBottomSlide/EditReviewBottomSlide.tsx
@@ -46,7 +46,7 @@ function EditReviewBottomSlide({
 
   const checkBeforeExit = {
     title: '잠깐!',
-    subText: '지금 나가면 작성내용이 전부 삭제돼요',
+    subText: '지금 나가면 수정내용이 전부 삭제돼요',
     cancelText: '마저 작성할게요',
     actionButton: '나갈래요',
     isSmallSize: true,
@@ -66,21 +66,20 @@ function EditReviewBottomSlide({
 
   const handlePatchMyReview = async () => {
     setIsDisabled(true);
+
+    const presignedUrls = await s3Request.uploadImages(imageFileList as File[]);
+
     if (imageFileList) {
-      const presignedUrls = await s3Request.uploadImages(imageFileList as File[]);
-
-      if (imageFileList) {
-        presignedUrls.map((url: string, i: number) => {
-          presignedUrls[i] = url.split('?')[0];
-        });
-      }
-      setImageUrls(presignedUrls);
+      presignedUrls.map((url: string, i: number) => {
+        presignedUrls[i] = url.split('?')[0];
+      });
     }
+
     await patchMyReview.mutateAsync({
       reviewId,
       rating: starCount,
       content: text,
-      images: imageUrls,
+      images: imageFileList ? presignedUrls : imageUrls,
       visitedAt: `${time.getFullYear()}-${('00' + (time.getMonth() + 1).toString()).slice(-2)}-01`,
     });
     toast('리뷰가 수정되었습니다.');
@@ -106,7 +105,7 @@ function EditReviewBottomSlide({
           }}
           className={styles.container__top__icon}
         >
-          <CloseIcon width='2rem' height='2rem' />
+          <CloseIcon width='2rem' height='2rem' onClick={slideOnClose} />
         </button>
         <div className={styles.container__top__title}>리뷰 수정</div>
       </div>

diff --git a/src/pages/User/MyReview/MyReview.tsx b/src/pages/User/MyReview/MyReview.tsx
@@ -98,7 +98,7 @@ function MyReview() {
 
               <p className={styles.myreview__content}>{content}</p>
 
-              {images && <ReviewImageSlider images={images} />}
+              <div style={{padding: '0 20px'}}>{images && <ReviewImageSlider images={images} />}</div>
             </li>
           )),
         )}

diff --git a/src/sass/abstracts/_mixin.scss b/src/sass/abstracts/_mixin.scss
@@ -1,6 +1,6 @@
 //재사용 가능한 스타일 믹스인을 정의합니다.
-@use "./variables";
-@use "sass:map";
+@use './variables';
+@use 'sass:map';
 
 @mixin typography($name) {
   font-size: map-get(variables.$typography-font-size-map, $name);
@@ -33,8 +33,6 @@
 
   display: flex;
 
-  padding: 0 20px;
-
   transition: all 0.5s;
 }