Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: create real time saving in votememo #160

Conversation

SKY-PEY
Copy link
Contributor

@SKY-PEY SKY-PEY commented Jan 23, 2024

개요

votememo 실시간 저장
조건부 처리 추가
바텀슬라이드 스크롤 방지
기획디자인 요청에 따른 기타 디자인 수정

스크린샷

localstorageMemo

주요 내용

  • 투표 메모 로컬스토리지 실시간 저장 및 페이지 이탈 이후 불러오기
  • 바텀슬라이드에 스크롤 방지 추가
  • 디자인 및 조건부 처리 추가
  • 버튼 토글함수 수정
  • 디바운스 커스텀훅 추가

고민한 점, 질문거리

api연결은 백엔드 쪽에서 아직 에러수정 중이라 진행중입니다

@JSH99 서현님 바텀슬라이드에 스크롤방지 관련 코드 추가했습니다!

@SKY-PEY SKY-PEY self-assigned this Jan 23, 2024
@SKY-PEY SKY-PEY linked an issue Jan 23, 2024 that may be closed by this pull request
4 tasks
Copy link

vercel bot commented Jan 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
trip-vote-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 11:25am

@SKY-PEY SKY-PEY added the feat label Jan 23, 2024
Copy link
Member

@Yamyam-code Yamyam-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/components/VoteTabPanel/VoteTabPanel.tsx(24,26): error TS6133: 'index' is declared but its value is never read. 빌드 오류있어요~~

@SKY-PEY SKY-PEY merged commit a06fde8 into dev Jan 23, 2024
3 checks passed
@SKY-PEY SKY-PEY deleted the 145-feat-create-a-candidate-add-function-in-search-place-and-wish-list branch January 23, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

Feat : create a candidate add function in Search place and Wish list
4 participants