Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

220 feat trip connect search #230

Merged
merged 4 commits into from
Jan 27, 2024
Merged

Conversation

Yamyam-code
Copy link
Member

@Yamyam-code Yamyam-code commented Jan 27, 2024

개요

스크린샷

주요 내용

  • 검색페이지 무한스크롤 구현
  • 투표 후보페이지 유사 카테고리 추천 장소 리스트 구현

고민한 점, 질문거리

투표 후보 추가 후 navigate가 저를 이상한 곳으로 데려다 주는 것 같습니다.
검색 로직에는 별점을 받아오는 것이 없어서 제거하였습니다. 별점 받는게 돈도 많이 들어서 아싸리 제거하도록 pm분들에게 말씀 드리는게 좋을 것 같습니다,

@Yamyam-code Yamyam-code linked an issue Jan 27, 2024 that may be closed by this pull request
1 task
Copy link

vercel bot commented Jan 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
trip-vote-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2024 5:29pm

@NamgungJongMin NamgungJongMin merged commit 24fdf1f into dev Jan 27, 2024
3 checks passed
@NamgungJongMin NamgungJongMin deleted the 220-feat-trip-connect-search branch January 27, 2024 17:40
@SKY-PEY
Copy link
Contributor

SKY-PEY commented Jan 27, 2024

저희를 이상한 곳으로 이끌던 내비를 제 로컬에서 수정했습니다,,ㅋㅋㅋ
혹시 제가 pr 올리기 전에 계속 확인이 필요하신거면 아래처럼 수정해서 쓰시면 될거에요
VoteMemo.tsx / handleAddCandidates에서 수정 navigate(`/trip/${spaceId}/votes/${voteInfo.id}`);

그리고 추천리스트 확인했습니다.... 짱... 혹시 궁금한거 있으면 물어보러 가겠습니다 고생 많으셨어요!🤗🤗🤗👍👍👍👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: trip connect search
5 participants