Feat: create home #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to 6-feat-create-home
Closed
2 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
메인으로 pr이 생성돼서 한번 확인 부탁드려요~ |
|
|
HOOOO98
previously approved these changes
Jan 5, 2024
src/mocks/handlers/home.ts
Outdated
Comment on lines
+18
to
+20
| ::-webkit-scrollbar { | ||
| display: none; | ||
| } |
There was a problem hiding this comment.
아..스크롤바도 지워야 하는군요
생각 못했네요 하하..
…/TripVote-FE into 6-feat-create-home
HOOOO98
reviewed
Jan 6, 2024
There was a problem hiding this comment.
냠냠코딩님 혹시 #25 pr 머지 될때 컨플릭트만 나오지 않았나요..?
너무 많아서 rebase 하셨나요?
HOOOO98
previously approved these changes
Jan 7, 2024
Yamyam-code
dismissed
HOOOO98’s stale review
The merge-base changed after approval.
SKY-PEY
previously approved these changes
Jan 7, 2024
Yamyam-code
dismissed
SKY-PEY’s stale review
The merge-base changed after approval.
HOOOO98
approved these changes
Jan 7, 2024
JSH99
approved these changes
Jan 7, 2024
| }), | ||
| ]; | ||
|
|
||
| // 추후 api폴더가 생기면 함수를 옮기겠습니다. |
NamgungJongMin
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
홈페이지 마크업
close #6
스크린샷
주요 내용
고민한 점, 질문거리