Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: mark up trip space page #37

Merged
merged 9 commits into from
Jan 7, 2024
Merged

Feat: mark up trip space page #37

merged 9 commits into from
Jan 7, 2024

Conversation

JSH99
Copy link
Member

@JSH99 JSH99 commented Jan 7, 2024

개요

여행 스페이스 페이지 마크업
close #10

스크린샷

주요 내용

  • 편집 Bottom Slide 구현
  • 여행 스페이스 페이지 마크업
  • 알림 페이지, 사이드 바 연결

⭐️ 공통 Bottom Slide 컴포넌트 생성

공통적으로 사용되는 bottom slide 생성해두었습니다. 피그마 기준 bottom sheet인데, chakra에서 제공하는 이름이 slide여서 bottom slide로 생성했습니다. 사용 방법 아래에 작성해두겠습니다.

const {
    isOpen: isBottomSlideOpen,
    onOpen: onBottomSlideOpen,
    onClose: onBottomSlideClose,
  } = useDisclosure();

<button onClick={onBottomSlideOpen}>
  편집
</button>
...
<BottomSlide
    isOpen={isBottomSlideOpen}
    onClose={onBottomSlideClose}
    children={<EditBottomSlideContent />}
/>

사용하고자 하는 페이지/컴포넌트에서 위처럼 작성해서 사용하시면 되고, chidren에 slide에 들어갈 내용에 해당되는 컴포넌트 넣어주시면 됩니다. 전체 코드는 Trip.tsx, BottomSlide.tsx, EditBottomSlideContent.tsx 파일 확인해주시면 됩니다!

고민한 점, 질문거리

@JSH99 JSH99 added the feat label Jan 7, 2024
@JSH99 JSH99 self-assigned this Jan 7, 2024
Copy link

vercel bot commented Jan 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
trip-vote ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2024 9:29am

Copy link
Contributor

@HOOOO98 HOOOO98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!ㅎㅎ
이거만 기다리고 있었어요!🙇🏻

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

얼른 올리려 했는데 수정사항이 있어서 조금 늦었습니다..😂

Copy link
Contributor

@SKY-PEY SKY-PEY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사히 잘 쓰겠습니다~~!! 😘

@JSH99 JSH99 merged commit e2f1e82 into dev Jan 7, 2024
3 checks passed
@JSH99 JSH99 deleted the 10-feat-mark-up-trip-space branch January 7, 2024 09:35
HOOOO98 pushed a commit that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants