Feat: create login page #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- markup page - apply styles
- way to reset input area - way to show remove input value button - way to write form area's markup div to section
Closed
3 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
HOOOO98
approved these changes
Jan 8, 2024
코멘트 다신건 이후 이슈 올리고 바로 적용하겠슴다~ |
JSH99
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
로그인 페이지 생성
스크린샷
주요 내용
고민한 점, 질문거리
react hook form에서 onsubmit 모드로 submit 마다 validation 결과를 반영하고 싶었으나 설정한 pattern의 validation을 통과하지 않으면 submit 기능 자체를 막아놓아서 submit으로 validation 결과를 렌더링 할 수 없음.
일단 submit 대신 onclick으로 이벤트 걸고 onchange모드로 변경. 추가적으로 확인할 예정
close #19