Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancing the documentation #37

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Enhancing the documentation #37

merged 2 commits into from
Jan 20, 2025

Conversation

tiagobstr
Copy link
Contributor

Enhancing the documentation by working on the following sections:

  • Updating broken links;
  • Semantic validation;
  • Symbol resolution
  • Code generation
  • Chisel method;
  • Dual Code Model APIs

@tiagobstr tiagobstr requested a review from ftomassetti January 6, 2025 15:56
@netlify Netlify
Copy link

netlify bot commented Jan 6, 2025 •
edited
Loading

❌ Deploy Preview for majestic-fenglisu-8c6786 failed.

Name Link
🔨 Latest commit 98f6523
🔍 Latest deploy log https://app.netlify.com/sites/majestic-fenglisu-8c6786/deploys/678e352e1b84950008d06804

ftomassetti
ftomassetti approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@ftomassetti ftomassetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very good to me. I added comments about small refinements, but overall this PR is a good step forward for this documentation

Writerside/topics/ChiselMethod.md Outdated Show resolved Hide resolved
Writerside/topics/ChiselMethod.md Show resolved Hide resolved
Writerside/topics/ChiselMethod.md Show resolved Hide resolved
Writerside/topics/CodeGeneration.md Outdated Show resolved Hide resolved
Writerside/topics/CodeGeneration.md Outdated Show resolved Hide resolved
Writerside/topics/DualCodeModelAPIs.md Show resolved Hide resolved
Writerside/topics/SemanticEnrichment.md Show resolved Hide resolved
Writerside/topics/SemanticEnrichment.md Show resolved Hide resolved
Writerside/topics/Serialization.md Outdated Show resolved Hide resolved
Writerside/topics/SymbolResolution.md Show resolved Hide resolved
@tiagobstr tiagobstr merged commit 8a17f7e into main Jan 20, 2025
1 of 5 checks passed
@tiagobstr tiagobstr deleted the update-documentation branch January 20, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ftomassetti ftomassetti ftomassetti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiagobstr @ftomassetti