Merge branch 'main' of https://github.com/Studio-23-xyz/com.studio23.…

…ss2.dialoguesystem
Studio-23-xyz · May 8, 2024 · f7f48e3 · f7f48e3
2 parents 0317a7c + 149800d
commit f7f48e3
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/Assets/Packages/com.studio23.ss2.dialoguesystem/Runtime/Core/DialogueSystem.cs b/Assets/Packages/com.studio23.ss2.dialoguesystem/Runtime/Core/DialogueSystem.cs
@@ -42,7 +42,6 @@ public class DialogueSystem : MonoBehaviour
         /// Subscribe to this to know when dialogue completed
         /// </summary>
         public DialogueLineEvent DialogueLineCompleted;
-
 
         void Awake()
         {
@@ -65,7 +64,6 @@ public void InitializeDialogueGraph(DialogueGraph newGraph)
             _currentGraph = newGraph;
         }
 
-
         /// <summary>
         /// Start playing dialogue and it Fires the Start event
         /// </summary>

diff --git a/.../Packages/com.studio23.ss2.dialoguesystem/Runtime/Data/xNode/Node/DialogueLineNodeBase.cs b/.../Packages/com.studio23.ss2.dialoguesystem/Runtime/Data/xNode/Node/DialogueLineNodeBase.cs
@@ -73,6 +73,7 @@ public override async UniTask Play()
                 Core.DialogueSystem.Instance.DialogueLineStarted?.Invoke(this);
                 while (!_canAdvanceDialogue)
                 {
+                    //at this point, we are showing dialogue with ShouldShowLineWhenSkipped = true
                     if (Core.DialogueSystem.Instance.IsSkipActive)
                     {
                         await UniTask.Delay(TimeSpan.FromSeconds(Core.DialogueSystem.Instance.ShowLineDurationWhenSkipping));