From e9c2c78878021034a80e07e501fdc37b0f5e2374 Mon Sep 17 00:00:00 2001 From: Chris Reed <55092742+cjreed121@users.noreply.github.com> Date: Fri, 30 Aug 2024 23:59:18 -0400 Subject: [PATCH] [Bugfix:Developer] Fix fork Docker org name (#44) ### Please check if the PR fulfills these requirements: * [ ] Tests for the changes have been added/updated (if possible) * [ ] Documentation has been updated/added if relevant ### What is the current behavior? On PRs from forks, the Docker repo variable will not be sent to the GitHub action. This causes the action to fail since it is missing a required argument. ### What is the new behavior? The action does not fail as the org name is now present. --- .github/workflows/docker-build-pr.yml | 2 +- .github/workflows/docker-build-push.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/docker-build-pr.yml b/.github/workflows/docker-build-pr.yml index 86c16fd..0bb0453 100644 --- a/.github/workflows/docker-build-pr.yml +++ b/.github/workflows/docker-build-pr.yml @@ -10,6 +10,6 @@ jobs: uses: submitty/action-docker-build/.github/workflows/docker-build-push.yml@v24.07.00 with: push: false - docker_org_name: ${{ vars.docker_org_name }} + docker_org_name: submitty base_commit: ${{ github.event.pull_request.base.sha }} head_commit: ${{ github.event.pull_request.head.sha }} diff --git a/.github/workflows/docker-build-push.yml b/.github/workflows/docker-build-push.yml index 6c2d9b8..a3f9775 100644 --- a/.github/workflows/docker-build-push.yml +++ b/.github/workflows/docker-build-push.yml @@ -10,7 +10,7 @@ jobs: uses: submitty/action-docker-build/.github/workflows/docker-build-push.yml@v24.07.00 with: push: true - docker_org_name: ${{ vars.docker_org_name }} + docker_org_name: submitty base_commit: ${{ github.event.before }} head_commit: ${{ github.event.after }} secrets: