-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature:Autograding] Add Prolog image #43
Conversation
I'm still a bit confused on how to contribute to this repository, so if this is wrong please let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's typically preferred to try and lock dependencies for good reproducibility in builds. Can we lock swi-prolog to it's current major version? And if so, it would probably be good to have the tag name be that major version rather than latest.
swipl seems to not allow installing versions? I think? Trying to install it with any version resulted in the below error. I can install the dpkg manually (like they do here) but I don't know if that would take too long to get and compile and run. |
Which version of prolog are you looking to install on this Docker image? Ubuntu repos for 22.04 only have up to 8.4.2. If you wanted to specify this version for apt you would use If you wanted a later version, you could look into using the PPA provided by swi-prolog. dpkg is definitely an option but let's try not to complicate this image too much. |
Last thing is to change the |
Please check if the PR fulfills these requirements:
What is the current behavior?
none
What is the new behavior?
we can now run prolog files
Other information?
this is not a breaking change and I tested it using: