Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ondersteuning voor referentie-implementatie #360

Open
wants to merge 40 commits into
base: master
Choose a base branch
from

Conversation

EduardWitteveen
Copy link

@haarlem-dvh Kun je eens controleren of deze uitwisselbaar is met jullie huidige versie?
gebruikte config ga ik seperaat via email naar je versturen

@jacodg Lees je mee? Ik denk dat dit nodig is om de nieuwe versie van de standaarden straks ook te kunnen ondersteunen

@haarlem-dvh
Copy link
Collaborator

haarlem-dvh commented Dec 18, 2023 via email

@EduardWitteveen
Copy link
Author

@jacodg Eigenlijk moet de ladybug ook nog de jwt-authenticatie meenemen denk ik, moeten we dan hier wat doen?
https://github.com/Sudwest-Fryslan/OpenZaakBrug/pull/360/files#diff-77bd0a5da83b73cb71c60d1664287e9812229ab22e9763714901f2af1b07ea17R100

@haarlem-dvh Heb je alweer wat tijd :-)

Eduard Witteveen and others added 4 commits February 6, 2024 17:56
…he wanted behaviour

- Config.json can now contain a default organisation, which will be used then not provided by the request
Copy link
Collaborator

@haarlem-dvh haarlem-dvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoi Eduard,
Helaas heb ik nog geen tijd gehad om deze branch lokaal tegen onze omgeving te testen.
Maar heb wel naar de code aanpassingen gekeken. Op paar kleine puntjes na volgens mij helemaal prima.

Groeten,
David

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wij gebruiken deze controller wel nog in onze testomgeving

// do we already have an endpoint for this jwt-token?
for(ZgwJwtTokenEntry entry : this.authorizations.values()) {
if (entry.jwtUrl == null) {
if(jwtUrl != null) continue;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dit kan in één if statement, toch?

continue;
}
// bestond al, geven we terug
log.debug("For url: " + url + " using: '" + entry.getAuthorization() + "' from previous found entry");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dit word toch juist geloged als hij nog niet bestaat? Je gaat hem daarna ook toevoegen.

@SerializedName("informatieobjecttype")
@Expose
public String informatieobjecttype;
// @SerializedName("versie")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deze regels mogen weg.

addZdsZaakDocumentInhoudToZgwEnkelvoudigInformatieObjectTypeMapping(modelMapper);

addZdsZaakDocumentInhoudToZgwEnkelvoudigInformatieObjectPostTypeMapping(modelMapper);
// is de volgende nog nodig?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blijkbaar niet, als alle testen goed gaan ;-)




// public void addZdsZaakDocumentInhoudToZgwEnkelvoudigInformatieObjectTypeMapping(ModelMapper modelMapper) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dan mag hij hier ook helemaal weg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants