Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge from main #58

Closed
wants to merge 60 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
a16ba30
Work in progress
Jun 29, 2023
6bb560e
feat: re-use afzender & onderwerp
DelanoWAF Jun 30, 2023
72780a8
Merge pull request #48 from Sudwest-Fryslan/fill-opslaanBijlage-fields
DelanoWAF Jun 30, 2023
b4f95db
chore(minor): release 6.3.0 [skip ci]
semantic-release-bot Jun 30, 2023
5c9308e
refactor: incorrect names and values
DelanoWAF Jun 30, 2023
c850e4b
chore(patch): release 6.3.1 [skip ci]
semantic-release-bot Jun 30, 2023
68096ea
refactor: incorrect table name
DelanoWAF Jun 30, 2023
4bafcd2
Merge branch 'main' of https://github.com/Sudwest-Fryslan/Webformulie…
DelanoWAF Jun 30, 2023
8f2e19a
chore(patch): release 6.3.2 [skip ci]
semantic-release-bot Jun 30, 2023
e9fc89b
refactor: change sessionkey type
DelanoWAF Jun 30, 2023
48251d3
Merge branch 'main' of https://github.com/Sudwest-Fryslan/Webformulie…
DelanoWAF Jun 30, 2023
2b9538d
chore(patch): release 6.3.3 [skip ci]
semantic-release-bot Jun 30, 2023
832ed1f
fix: incorrect input for XSLTPipes
DelanoWAF Jun 30, 2023
8fe299a
Merge branch 'main' of https://github.com/Sudwest-Fryslan/Webformulie…
DelanoWAF Jun 30, 2023
74806c8
chore(patch): release 6.3.4 [skip ci]
semantic-release-bot Jun 30, 2023
1dee808
TestCase NietNatuurlijkpersoon toegevoegd
Jun 30, 2023
14fe288
Merge remote-tracking branch 'origin/main' into main
Jun 30, 2023
948a110
fix: sync custom code with latest ff (#50)
jacodg Jul 2, 2023
1fd3381
fix: Improve error handling (#49)
mhdirkse Jul 2, 2023
5d68e6c
chore(patch): release 6.3.5 [skip ci]
semantic-release-bot Jul 2, 2023
84b9861
feat: add first iteration opslaanInkNietNatuurlijkPersoon
DelanoWAF Jul 3, 2023
511e6e6
Merge pull request #51 from Sudwest-Fryslan/add-opslaanInkNietNatuurl…
DelanoWAF Jul 3, 2023
66ae9db
fix: renaming issues
DelanoWAF Jul 3, 2023
29a2b22
refactor: rename pipe SetONum
DelanoWAF Jul 3, 2023
d620003
feat: add company registration to dispatcher
DelanoWAF Jul 3, 2023
2a42f41
fix: incorrect xslt variable
DelanoWAF Jul 3, 2023
d674de8
Merge pull request #52 from Sudwest-Fryslan/add-opslaanInkNietNatuurl…
DelanoWAF Jul 3, 2023
6880e36
chore(minor): release 6.4.0 [skip ci]
semantic-release-bot Jul 3, 2023
6e4864d
feat: version publiccode.yaml automatically
Jul 3, 2023
efa742e
fix: add missing parameter
DelanoWAF Jul 3, 2023
5dfd83d
chore(patch): release 6.4.1 [skip ci]
semantic-release-bot Jul 3, 2023
18da36a
fix: CI/CD should check in configurations/WebformulierenVerwerker/Bui…
Jul 3, 2023
52fe700
Merge branch 'docsConventionalCommits' into cicd_20230703
Jul 3, 2023
a4c08d9
fix: check in publiccode.yaml
Jul 3, 2023
11a3694
docs: update CONTRIBUTING.md
Jul 3, 2023
6361c74
Merge pull request #53 from Sudwest-Fryslan/cicd_20230703
philipsens Jul 3, 2023
b0ca9de
chore(minor): release 6.5.0 [skip ci]
semantic-release-bot Jul 3, 2023
63fc149
refactor: limit query to 1 result
DelanoWAF Jul 4, 2023
6ac45c1
refactor: skip pipes if no afzender
DelanoWAF Jul 4, 2023
6418228
refactor: change object type for company registration
DelanoWAF Jul 4, 2023
b8f6ff8
Merge pull request #55 from Sudwest-Fryslan/minor-adjustments
DelanoWAF Jul 4, 2023
b0f753b
chore(patch): release 6.5.1 [skip ci]
semantic-release-bot Jul 4, 2023
17ab996
fix: enable SOAP validation again (#54)
mhdirkse Jul 4, 2023
5aa940c
chore(patch): release 6.5.2 [skip ci]
semantic-release-bot Jul 4, 2023
40b833d
fix: incorrect xslt issue
DelanoWAF Jul 4, 2023
e64db7e
Merge pull request #56 from Sudwest-Fryslan/more-minor-adjustments
DelanoWAF Jul 4, 2023
c72fa3d
refactor: parameterize docker compose and add update script
philipsens Jul 4, 2023
a390eae
fix: incorrect XSLT element
DelanoWAF Jul 4, 2023
e03a8d9
chore(patch): release 6.5.4 [skip ci]
semantic-release-bot Jul 4, 2023
6c6b5ad
refactor: add new function to outputvalidator
DelanoWAF Jul 4, 2023
0d92819
Merge branch 'main' of https://github.com/Sudwest-Fryslan/Webformulie…
DelanoWAF Jul 4, 2023
9944019
fix: connection pool shut down
jacodg Jul 4, 2023
4fe8101
refactor: parameterize docker compose and add update script
philipsens Jul 4, 2023
42c6fae
refactor: pipe path fix
DelanoWAF Jul 4, 2023
9169c3e
chore(patch): release 6.5.6 [skip ci]
semantic-release-bot Jul 4, 2023
16d4493
Merge pull request #57 from Sudwest-Fryslan/fix--connection-pool-shut…
DelanoWAF Jul 4, 2023
7df74ea
chore(patch): release 6.5.7 [skip ci]
semantic-release-bot Jul 4, 2023
f163e0b
refactor: add relationID to CreateMetaDocument
DelanoWAF Jul 5, 2023
823a0ca
chore(patch): release 6.5.8 [skip ci]
semantic-release-bot Jul 5, 2023
61f158b
Merge branch 'improve-error-handling' into main
DelanoWAF Jul 5, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .env.example
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
VERSION=6
PORT=8080

jdbc.datasource.default=jdbc/webformulierenverwerker-postgresql
3 changes: 3 additions & 0 deletions .github/workflows/writeBuildInfo.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ if [[ -n $1 ]]; then
echo "versionDate_ddmmyyyy=$(date +%d/%m/%Y)" >> classes/BuildInfo.properties
echo "configuration.version=$1" > configurations/WebformulierenVerwerker/BuildInfo.properties
echo "configuration.timestamp=$(date +%Y%m%d-%H%M%S)" >> configurations/WebformulierenVerwerker/BuildInfo.properties
export instance_version=$1
export versionDate_yyyymmdd=$(date +%Y-%m-%d)
envsubst < publiccode_template.yaml > publiccode.yaml
else
echo "writeBuildInfo.sh - no version to write, leaving BuildInfo.properties unchanged"
fi
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ FrankConfig.xsd
# .env should be made in the environment.
# It is an additional file to StageSpecifics_LOC to keep it more generic.
.env
.idea/
4 changes: 3 additions & 1 deletion .releaserc
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,9 @@
{
"assets": [
"CHANGELOG.md",
"classes/BuildInfo.properties"
"classes/BuildInfo.properties",
"configurations/WebformulierenVerwerker/BuildInfo.properties",
"publiccode.yaml"
],
"message": "chore(<%= nextRelease.type %>): release <%= nextRelease.version %> <%= nextRelease.channel !== null ? `on ${nextRelease.channel} channel ` : '' %>[skip ci]\n\n<%= nextRelease.notes %>"
}
Expand Down
131 changes: 131 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,136 @@
[![conventional commits](https://img.shields.io/badge/conventional%20commits-1.0.0-yellow.svg)](https://conventionalcommits.org) [![semantic versioning](https://img.shields.io/badge/semantic%20versioning-2.0.0-green.svg)](https://semver.org)

## [6.5.8](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/compare/v6.5.7...v6.5.8) (2023-07-05)


### 🧑‍💻 Code Refactoring

* add relationID to CreateMetaDocument ([f163e0b](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/f163e0b3a56ae0841859de282d256674b50cbb9a))

## [6.5.7](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/compare/v6.5.6...v6.5.7) (2023-07-04)


### 🐛 Bug Fixes

* connection pool shut down ([9944019](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/9944019960c893ce6d383d95010e5c5e983bc00e))

## [6.5.6](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/compare/v6.5.5...v6.5.6) (2023-07-04)


### 🧑‍💻 Code Refactoring

* pipe path fix ([42c6fae](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/42c6faee55f276ce9f584be05fa77fee7dcce6c1))

## [6.5.4](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/compare/v6.5.3...v6.5.4) (2023-07-04)


### 🐛 Bug Fixes

* incorrect XSLT element ([a390eae](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/a390eae9fde47b6cb2a49267fd9592357cfc54c2))

## [6.5.2](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/compare/v6.5.1...v6.5.2) (2023-07-04)


### 🐛 Bug Fixes

* enable SOAP validation again ([#54](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/issues/54)) ([17ab996](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/17ab99662af4cbaa487abd690f18bb7eabf949dc))

## [6.5.1](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/compare/v6.5.0...v6.5.1) (2023-07-04)


### 🧑‍💻 Code Refactoring

* change object type for company registration ([6418228](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/64182285daac0e90f56ea3d237acb10b777564b8))
* limit query to 1 result ([63fc149](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/63fc149a693181cb56e883acdb0e59ae35da4496))
* skip pipes if no afzender ([6ac45c1](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/6ac45c148ee472288d4cc5b9cbf5e88294de47c9))

## [6.5.0](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/compare/v6.4.1...v6.5.0) (2023-07-03)


### 🍕 Features

* version publiccode.yaml automatically ([6e4864d](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/6e4864d0d59ec6daefbcebdca0ed850de495a7b3))


### 🐛 Bug Fixes

* check in publiccode.yaml ([a4c08d9](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/a4c08d961895d7c36ea2bd8fd7c6c8d44832a9d9))
* CI/CD should check in configurations/WebformulierenVerwerker/BuildInfo.properties ([18da36a](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/18da36aebdeec700a121756b1e9142879b40e4de))


### 📝 Documentation

* update CONTRIBUTING.md ([11a3694](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/11a36948e0efeebdbed098699908f61abab6d6b4))

## [6.4.1](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/compare/v6.4.0...v6.4.1) (2023-07-03)


### 🐛 Bug Fixes

* add missing parameter ([efa742e](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/efa742e7f54e51a0473ff8c57ba237eed5de9ef2))

## [6.4.0](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/compare/v6.3.5...v6.4.0) (2023-07-03)


### 🍕 Features

* add company registration to dispatcher ([d620003](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/d620003fd6f48b73d642284afcfea6dbf0237246))
* add first iteration opslaanInkNietNatuurlijkPersoon ([84b9861](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/84b98612436ce211f31bf1703816665d40daf1bf))


### 🐛 Bug Fixes

* incorrect xslt variable ([2a42f41](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/2a42f418daf24e4d973c1cae5d622681c2f1863c))
* renaming issues ([66ae9db](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/66ae9dbafefebf2722ed0c9b34787ad082bae63a))


### 🧑‍💻 Code Refactoring

* rename pipe SetONum ([29a2b22](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/29a2b220c2d58478b6837e79dcd14a364bee04e7))

## [6.3.5](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/compare/v6.3.4...v6.3.5) (2023-07-02)


### 🐛 Bug Fixes

* Improve error handling ([#49](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/issues/49)) ([1fd3381](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/1fd338180bab1290a715b972c4159aa1244e2d6b))
* sync custom code with latest ff ([#50](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/issues/50)) ([948a110](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/948a110bf47a84ff68a9479c7cd45042a195f9f4))

## [6.3.4](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/compare/v6.3.3...v6.3.4) (2023-06-30)


### 🐛 Bug Fixes

* incorrect input for XSLTPipes ([832ed1f](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/832ed1f1a1c772010ef78001109c0081fdc94f78))

## [6.3.3](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/compare/v6.3.2...v6.3.3) (2023-06-30)


### 🧑‍💻 Code Refactoring

* change sessionkey type ([e9fc89b](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/e9fc89ba9985bd7d3460aa7ed9b22e007d901755))

## [6.3.2](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/compare/v6.3.1...v6.3.2) (2023-06-30)


### 🧑‍💻 Code Refactoring

* incorrect table name ([68096ea](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/68096ea7acd188c198cd89ec99b35bfb3f5e1fad))

## [6.3.1](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/compare/v6.3.0...v6.3.1) (2023-06-30)


### 🧑‍💻 Code Refactoring

* incorrect names and values ([5c9308e](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/5c9308e3bf27b426f5119d0e9cbe88c43e4803c3))

## [6.3.0](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/compare/v6.2.14...v6.3.0) (2023-06-30)


### 🍕 Features

* re-use afzender & onderwerp ([6bb560e](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/commit/6bb560eae45d396c94f876bde76065ef5c0c20a0))

## [6.2.14](https://github.com/Sudwest-Fryslan/WebformulierenVerwerker/compare/v6.2.13...v6.2.14) (2023-06-29)


Expand Down
13 changes: 10 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
# Deliverables

This project builds the following artifacts:
* A docker image that can be used to run this application stand-alone.
* A .jar file with only the Frank configuration of this project. The .jar file can be uploaded in het-integratie-platform, see https://github.com/wearefrank/het-integratie-platform.

# CI/CD

Releases are created automatically by GitHub Actions, see [.github/workflows/ci-build.yml](.github/workflows/ci-build.yml).
We use conventional commits, see https://www.conventionalcommits.org/en/v1.0.0/. Releases are created automatically by GitHub Actions, see [.github/workflows/ci-build.yml](.github/workflows/ci-build.yml).

Please take care to write meaningful commit messages that result in meaningful entries in [CHANGELOG.md](CHANGELOG.md). Here is an example of the commit message for a breaking change:

Expand All @@ -19,19 +25,20 @@ A breaking change means that this version is not backwards compatible with the p
* The commit type (e.g. chore) is still relevant for breaking changes. This information appears in the release notes in the same way as a non-breaking change.
* For non-breaking changes, omit the line with BREAKING and make a commit message like the first line shown.

# Checklist for testing CI/CD

Here is a checklist for testing the CI/CD.

* Testing goes best when you make hot fixes on the main branch. Check with the team that you are allowed to do this.
* Do a commit on main that has a commit message starting with `fix:`. The following should happen:
* The pipeline succeeds - this checks all authorizations are in place.
* A commit with a message starting with `chore:` has been added automatically.
* The extra commit updates files `classes/BuildInfo.properties` and `CHANGELOG.md`.
* The extra commit updates files `classes/BuildInfo.properties`, `configurations/WebformulierenVerwerker/BuildInfo.properties`, `publiccode.yaml` and `CHANGELOG.md`.
* These files should have trustworthy contents - speaks for itself.
* On GitHub, there is a tag for the new version that starts with `v`. For example if the new release is `3.2.1` then the tag should be `v3.2.1`. You can get this tag using `git fetch origin` on the command line.
* The docker image for the release has been created on http://www.dockerhub.com. The `latest` tag should have been updated - creation time should be the current time. Depending on the type of release, the `3.2.1`, the `3.2` or the `3` tags should be the current date.
* Check on dockerhub that tags that should not have been updated do not have the current time as creation time.
* Run the docker image using `docker run -p 8080:8080 wearefrank/webformulierenverwerker:3.2.1`. Check the name of the docker container you started using `docker ps -a`. Login to the docker container using `docker exec -it <container name> bash`. Check that `/opt/frank/resources/BuildInfo.property` contains the right version and the right date.
* Run the docker image using `docker run -p 8080:8080 wearefrank/webformulierenverwerker:3.2.1`. Check the name of the docker container you started using `docker ps -a`. Login to the docker container using `docker exec -it <container name> bash`. Check that `/opt/frank/resources/BuildInfo.property` and `/opt/frank/configurations/WebformulierenVerwerker/BuildInfo.properties` contain the right version and the right date.
* Check a breaking change like above. This should update the major version.
* Do a commit with \[skip ci\] in the commit message. It should not make a release and it should not push a docker image.
* Make a pull request. Check that no release is made and that no docker image is pushed.
1 change: 1 addition & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ COPY --chown=tomcat lib/server/ /usr/local/tomcat/lib/
COPY --chown=tomcat java /tmp/java
RUN javac \
/tmp/java/nl/nn/adapterframework/http/HttpSenderBase.java \
/tmp/java/nl/nn/adapterframework/http/HttpSessionBase.java \
-classpath "/usr/local/tomcat/webapps/ROOT/WEB-INF/lib/*:/usr/local/tomcat/lib/*" \
-verbose -d /usr/local/tomcat/webapps/ROOT/WEB-INF/classes
RUN rm -rf /tmp/java
Expand Down
8 changes: 2 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
# WebformulierenVerwerker

Documentation can be found in Jira > Gemeente Team > [GT-36](https://wearefrank-devops.atlassian.net/browse/GT-36).
Communicate between Kodison and Corsa. This configuration transforms incoming Kodison messages and makes them into Corsa requests. The responses are then transformed into messages accepted by Kodison.

Please build docker image as follows:

```
docker build -t sudwestfryslan.nl/webformulierenverwerker .
```
This application processes SOAP requests that satisfy a WSDL that has been copied from the predecessor of this bridge. The WSDL is included in this project.
4 changes: 2 additions & 2 deletions classes/BuildInfo.properties
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
instance.version=6.2.14
versionDate_ddmmyyyy=29/06/2023
instance.version=6.5.8
versionDate_ddmmyyyy=05/07/2023
4 changes: 2 additions & 2 deletions configurations/WebformulierenVerwerker/BuildInfo.properties
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
configuration.version=6.1.7
configuration.timestamp=20230626-145819
configuration.version=6.5.8
configuration.timestamp=20230705-073540
Loading
Loading