Skip to content

Commit

Permalink
Clean up, add TODOs & decision docs notes
Browse files Browse the repository at this point in the history
  • Loading branch information
plocket committed Sep 7, 2024
1 parent e2a3982 commit 4a3ad5d
Show file tree
Hide file tree
Showing 6 changed files with 108 additions and 428 deletions.
4 changes: 2 additions & 2 deletions lib/docassemble/server_install.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,5 +52,5 @@ session_vars.validateEnvironment();
const argv = require(`minimist`)(process.argv.slice(2));
const log = new Log({ path: argv.path, context: `server_install` });

// 3. run in a wrapper
log.with_cleanup({ todo: server_install });
// 3. run
server_install();
4 changes: 2 additions & 2 deletions lib/docassemble/setup.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,5 +71,5 @@ session_vars.validateEnvironment();
const argv = require(`minimist`)(process.argv.slice(2));
const log = new Log({ path: argv.path, context: `setup` });

// 3. run in a wrapper
log.with_cleanup({ todo: setup });
// 3. run
setup();
4 changes: 2 additions & 2 deletions lib/docassemble/takedown.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,5 @@ session_vars.validateEnvironment();
const argv = require(`minimist`)( process.argv.slice(2) );
const log = new Log({ path: argv.path, context: `takedown` });

// 3. run in a wrapper
log.with_cleanup({ todo: takedown });
// 3. run
takedown();
4 changes: 2 additions & 2 deletions lib/run_cucumber.js
Original file line number Diff line number Diff line change
Expand Up @@ -197,5 +197,5 @@ const argv = require(`minimist`)( process.argv.slice(2) );
// their own file.
const log = new Log({ path: argv.path, context: `run` });

// 3. run in a wrapper
log.with_cleanup({ todo: main });
// 3. run
main();
8 changes: 5 additions & 3 deletions lib/steps.js
Original file line number Diff line number Diff line change
Expand Up @@ -1441,10 +1441,12 @@ After(async function(scenario) {
}

// Not sure if this is necessary
if ( changeable_test_status !== 'PASSED' ) {
log.stdout({ records_only: true }, changeable_test_status[0].toUpperCase() );
} else {
if ( changeable_test_status === 'PASSED' ) {
log.stdout({ records_only: true }, `.` );
} else if ( changeable_test_status === `SKIPPED` ) {
log.stdout({ records_only: true }, `-` );
} else {
log.stdout({ records_only: true }, changeable_test_status[0].toUpperCase() );
}

let signout_succeeded = true;
Expand Down
Loading

0 comments on commit 4a3ad5d

Please sign in to comment.