Clean up code, clarify CHANGELOG

Co-authored-by: Bryce Willey <Bryce.Steven.Willey@gmail.com>

CHANGELOG.md

@@ -58,7 +58,7 @@ Format:
 - Docassemble Project name prefix now includes ALKiln in it for clarity
 
 ### Fixed
-- DOCKER UPDATE (for ALKilnInThePlayground): Allows ALKilnInThePlayground to upload files (though S3 is not consistent yet). See https://github.com/SuffolkLITLab/docassemble-ALKilnInThePlayground/issues/18. This may require some developers to update their system (updating their docker image) as described in [the documentation](https://suffolklitlab.org/legal-tech-class/docs/practical-guide-docassemble/maintaining-docassemble#updates-to-the-docassemble-container). Updating to a new docker images is something that all docassemble users will have to do sometime anyway, sometimes for security.
+- DOCKER UPDATE (for ALKilnInThePlayground): Allows ALKilnInThePlayground to upload files (though S3 is not consistent yet). See https://github.com/SuffolkLITLab/docassemble-ALKilnInThePlayground/issues/18. This may require some developers to update their system (updating their docker image) if they are below [docassemble-os 1.0.8](https://github.com/jhpyle/docassemble-os/releases/tag/v1.0.8). You can tell if you are below docassemble-os 1.0.8 if you run `docker image inspect jhpyle/docassemble | grep Created` on your host server (Lightsail, etc.) and the created date is before 2023-04-09. You can update as described in [the documentation](https://suffolklitlab.org/legal-tech-class/docs/practical-guide-docassemble/maintaining-docassemble#updates-to-the-docassemble-container). Updating to a new docker images is something that all docassemble users will have to do sometime anyway, sometimes for security.
 - Conform upload file behavior to that of other Story Table rows - avoid erroring when field isn't set properly unless using all variables is required.
 - Projects created in da each have a unique name. https://github.com/SuffolkLITLab/ALKiln/issues/663
 - Shorten path names to try to accommodate limitations of windows systems while still keeping enough useful information to help devs identify the test outputs. https://github.com/SuffolkLITLab/ALKiln/issues/618

lib/scope.js

@@ -1798,10 +1798,6 @@ module.exports = {
         [ `/usr/share/docassemble/files/playgroundsources/${session_vars.get_user_id()}/${session_vars.get_user_project_name()}` ],
         { onlyFiles: false, suppressErrors: true }
       );
-
-      // TODO: This dir doesn't hold onto files (according to feedback). We
-      // need to find a better way to get these files from S3. Python lib s4cmd
-      // was recommended.
       let files_s3 = fg.sync(
         [ `/tmp/playgroundsources/${session_vars.get_user_id()}/${session_vars.get_user_project_name()}` ],
         { onlyFiles: false, suppressErrors: true }
@@ -1835,7 +1831,6 @@ module.exports = {
       let matching_paths = [];
       if ( dir === null ) {
         for ( let one_dir of dirs ) {
-          // console.log( one_dir );
           matching_paths = fg.sync([ `${ one_dir }/${ trimmed_name }` ]);
           if ( matching_paths.length > 0 ) {
             // Once we've found a matching file, we choose to use that directory