Close #706 improve loops #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Splitting this PR into parts to describe my thoughts on each
- the technical change to fix Improve using
.target_numberin Story Table #706: pretty good! I like the additions, and the changes aren't too bad. - documentation of the current looping stuff: I think this doesn't really work as intended; just from the ordering of the files in the PR, I read though this before reading over the code changes, and I found myself very confused. But after I read the code itself, it made a lot more sense. If it's helpful for you, we can leave it in, but if you wanted it to help other developers, I don't think it's going to do that, and we should improve it.
- test refactors; I noted my thoughts in the comments, but I'm okay with these, even if I think we could do with better unit testing
plocket
commented
Jun 14, 2023
plocket
commented
Jun 14, 2023
plocket
commented
Jun 14, 2023
BryceStevenWilley
approved these changes
Jul 5, 2023
Something about changing the same line in multiple ways...? Co-authored-by: Bryce Willey <Bryce.Steven.Willey@gmail.com> Fix typo 2. GitHub won't let me do more at one time. Co-authored-by: Bryce Willey <Bryce.Steven.Willey@gmail.com> Fix typo 3. GitHub won't let me do more at one time. Co-authored-by: Bryce Willey <Bryce.Steven.Willey@gmail.com> Fix typo 4. GitHub won't let me do more at one time. Co-authored-by: Bryce Willey <Bryce.Steven.Willey@gmail.com> Fix typo 5. GitHub won't let me do more at one time. Co-authored-by: Bryce Willey <Bryce.Steven.Willey@gmail.com> Fix typo 6. GitHub won't let me do more at one time. Co-authored-by: Bryce Willey <Bryce.Steven.Willey@gmail.com> Address typos 7. Apparently this was the problem.
Co-authored-by: Bryce Willey <Bryce.Steven.Willey@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a biggie and might actually deal with a bug I wasn't aware of with
.target_number, which was inconsistent depending on whether the author defined.there_are_anyor not.I also wrote docs on how the flow works now.
Closes #706, improve loops.