Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freeze deps for v5 #733

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Freeze deps for v5 #733

merged 2 commits into from
Jul 17, 2023

Conversation

plocket
Copy link
Collaborator

@plocket plocket commented Jul 17, 2023

Sorry a previous commit for a bump snuck in here. Wasn't sure if there's a reason we were avoiding freezing these.

BryceStevenWilley
BryceStevenWilley approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@BryceStevenWilley BryceStevenWilley left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This would be to prevent someone from running npm update and changing things, and npm install will now only use what's in shrinkwrap I believe. Still useful though

@plocket plocket merged commit 1d1cb4e into v5 Jul 17, 2023
2 checks passed
@plocket plocket deleted the freeze branch July 17, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BryceStevenWilley BryceStevenWilley BryceStevenWilley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plocket @BryceStevenWilley