BREAKING: Remove EXTRA_LANGUAGES, now using cucumber Examples
#735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryceStevenWilley
approved these changes
Jul 17, 2023
.gitignore
Outdated
There was a problem hiding this comment.
This is fine, but IMO we should leave them in, in case you or I have some lang_*.feature files hanging around still
This was
linked to
issues
Jul 17, 2023
This was referenced Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #444, closes #337, closes #59 (EXTRA_LANGUAGES issues). This also removes all the places where languages are set and referenced. It's not completely necessary because the code works just fine when
EXTRA_LANGUAGESisundefined, but it is a bit more cleanup.[I'm not sure it's absolutely necessary, but it is good to clean up.]