Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal: Fix wrong input type being used in our github server workflow file #829

Draft
wants to merge 4 commits into
base: v5
Choose a base branch
from
Draft

Internal: Fix wrong input type being used in our github server workflow file #829

wants to merge 4 commits into from

Commits on Dec 4, 2023

  1. Troubleshoot workflow input enable_tmate 

    Try the solution here: https://stackoverflow.com/a/70077545/14144258 to use `fromJSON` and echo that value
    @plocket
    plocket authored Dec 4, 2023
    Configuration menu
    Copy the full SHA
    8a8da6a View commit details
    Browse the repository at this point in the history

  2. Use inputs.var as opposed to github.event.input.var

    @plocket
    plocket authored Dec 4, 2023
    Configuration menu
    Copy the full SHA
    dc93d98 View commit details
    Browse the repository at this point in the history

  3. Use toJson() instead of fromJson()

    @plocket
    plocket authored Dec 4, 2023
    Configuration menu
    Copy the full SHA
    f783099 View commit details
    Browse the repository at this point in the history

  4. Compare to 'true', I suppose, since boolean didn't work before

    @plocket
    plocket authored Dec 4, 2023
    Configuration menu
    Copy the full SHA
    4756c32 View commit details
    Browse the repository at this point in the history