Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better method to detect helm chart version in template tests #3627

Open
kasia-kujawa opened this issue Mar 29, 2024 · 1 comment
Open

Better method to detect helm chart version in template tests #3627

kasia-kujawa opened this issue Mar 29, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@kasia-kujawa
Copy link
Contributor

It would be good to have better method to detect helm chart version in helm templates.
Sometimes container image can have same image tag as our helm chart, in current form of template tests this container tag will be replaced to %CURRENT_CHART_VERSION%

related to #3626

@sumo-drosiek
Copy link
Contributor

There is limited number of cases:

➜  sumologic-kubernetes-collection git:(main) ✗ grep '%CURRENT_CHART_VERSION%' -hR tests/helm/testdata/goldenfile | sed 's/^ *//;' | sort | uniq
app.kubernetes.io/version: "%CURRENT_CHART_VERSION%"
chart: "sumologic-%CURRENT_CHART_VERSION%"
chart: sumologic-%CURRENT_CHART_VERSION%
client: k8s_%CURRENT_CHART_VERSION%
description = "Sumo Logic Kubernetes Collection\nversion: %CURRENT_CHART_VERSION%"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants