From bfe504abb7adc48389a6d6d31aecdcc7df73809f Mon Sep 17 00:00:00 2001 From: Katarzyna Kujawa Date: Fri, 29 Mar 2024 13:08:29 +0100 Subject: [PATCH] fix(test): get rid of unsafe regular expression for chart version replacing --- tests/helm/goldenfile_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/helm/goldenfile_test.go b/tests/helm/goldenfile_test.go index 1a285500ee..8a83755a63 100644 --- a/tests/helm/goldenfile_test.go +++ b/tests/helm/goldenfile_test.go @@ -132,10 +132,10 @@ func runGoldenFileTest(t *testing.T, valuesFileName string, outputFileName strin // expected templates func fixupRenderedYaml(yaml string, chartVersion string) string { checksumRegex := regexp.MustCompile("checksum/config: [a-z0-9]{64}") - chartsRegex := regexp.MustCompile("([^kubernetes-setup:])" + chartVersion) + output := yaml output = strings.ReplaceAll(output, releaseName, "RELEASE-NAME") - output = chartsRegex.ReplaceAllString(output, "$1%CURRENT_CHART_VERSION%") + output = strings.ReplaceAll(output, chartVersion, "%CURRENT_CHART_VERSION%") output = checksumRegex.ReplaceAllLiteralString(output, "checksum/config: '%CONFIG_CHECKSUM%'") output = strings.TrimSuffix(output, "\n") return output