Skip to content

Commit

Permalink
reverting changes - didn't mean to commit master
Browse files Browse the repository at this point in the history
  • Loading branch information
@chetan201
chetan201 authored Feb 7, 2018
1 parent 610b7db commit 904ecae
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pvmismatch/contrib/gen_coeffs/example.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
isat1, isat2, rs, rsh = x

pvc = pvcell.PVcell(
Rs=rs, Rsh=rsh, Isat1_T0=isat1, Isat2_T0=isat2,
Rs=rs, Rsh=rsh, Isat1_T0=isat1, Isat2=isat2,
Isc0_T0=ISC0/NP, alpha_Isc=AISC
)
f1 = plt.figure()
Expand Down

1 comment on commit 904ecae

@mikofski
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chetan201 you should fork this to your personal GitHub profile and then clone that down to your laptop as "origin":

$ git clone git@github.com:chetan201/PVMismatch.git

then set sunpower as the "upstream" remote:

$ cd PVMismatch
PVMismatch $ git remote add upstream git@github.com:SunPower/PVMismatch.git

Then create a "feature" branch on our laptop

PVMismatch $ git checkout -b Isat2fix

and push that feature to your personal GitHub profile:

PVMismatch $ git push -u origin Isat2fix

then when you go to GitHub, you will see a bubble asking you if you want to open a PR to SunPower/master

This is called the "feature-branch" workflow and if you follow it you will never make a mistake like this again.

Please read "the winning workflow" which explains it. Also this talk I gave last year at BIDS: the hacker within might interest you.

Please sign in to comment.