Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: np.zeros input formatted incorrectly in rtp.py #404

Open
1 of 3 tasks
carleyjmartin opened this issue Sep 12, 2024 · 0 comments · May be fixed by #407
Open
1 of 3 tasks

BUG: np.zeros input formatted incorrectly in rtp.py #404

carleyjmartin opened this issue Sep 12, 2024 · 0 comments · May be fixed by #407

Comments

@carleyjmartin
Copy link
Collaborator

BUG

We noticed that np.zeros in rtp.py line 344 is incorrectly formatted.
This line hasn't been changed in over 5 years so assuming the conditions that cause this to trigger are not done very often as we haven't had any complaints about it yet - to the point where we can't get it to to trigger a lot of the time.

I recommend checking all uses of np.zeros across pyDARN to check for this error as there are two instances in rtp.py where the line should read np.zeros([1, y_max]) instead of np.zeros(1, y_max).

I also recommend looking at refactoring this section of code to make it more obvious in what it's trying to do.

Priority

  • Minor - typo, incorrect naming, fails on specific uncommon situation
  • Major - misrepresentation of data, failure in a common situation
  • Urgent - failure in usage, large misrepresentation
@RemingtonRohel RemingtonRohel linked a pull request Oct 9, 2024 that will close this issue
@RemingtonRohel RemingtonRohel linked a pull request Oct 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant