Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supervisor daemon fails to start if log directory does not exist #1143

Closed
rzaharenkov opened this issue Aug 30, 2018 · 3 comments
Closed

Supervisor daemon fails to start if log directory does not exist #1143

rzaharenkov opened this issue Aug 30, 2018 · 3 comments
Labels

Comments

@rzaharenkov
Copy link

rzaharenkov commented Aug 30, 2018

In my opinion supervisor daemon itself should be super reliable and start even if there is any issue with configuration of particular programs.

In my case I am deploying my application in 2 steps:

  1. Bootstrap server using chef (install packages and create configuration files).
  2. Deploy application using capistrano (fetches application from github and restart particular services using supervisorctl restart my_group:*.

I run 1st step first time when I am bootstrapping new machine or when I do any changes to software or system configuration. 2nd step is running in order to release new version of application code.

So after very first running of chef I am ending up with broken supervisor (service is dead) because it can't find directory. Then run capistrano in order to deploy application 1st time (it creates all the required directories) and tries to restart services using supervisorctl but fails. So I need to run chef 1 more time which is inconvenience.

I do believe if something is wrong with single program configuration then supervisor daemon itself should start but program should be in failed state.

@mnaberez
Copy link
Member

Duplicate of #120

@mnaberez mnaberez marked this as a duplicate of #120 Aug 30, 2018
@rzaharenkov
Copy link
Author

rzaharenkov commented Sep 6, 2018

@mnaberez, I am not talking here about creating of log directory automatically. I aim is to ignore this error because it's not critical. Imagine you have 100 programs in the config and only 1 references to a directory that doesn't exist. What should happen? I think it's more than logical that daemon should start, print warning message to the log and mark 1 program as failed.

@mnaberez
Copy link
Member

mnaberez commented Sep 7, 2018

I aim is to ignore this error because it's not critical. Imagine you have 100 programs in the config and only 1 references to a directory that doesn't exist. What should happen?

#120 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants