Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try making log dir when log dir did not exist #1064

Closed
wants to merge 1 commit into from

Conversation

FAKERINHEART
Copy link

No description provided.

@mnaberez
Copy link
Member

#1006 (comment)

@mnaberez mnaberez closed this Feb 26, 2018
@FAKERINHEART
Copy link
Author

FAKERINHEART commented Feb 27, 2018

@mnaberez
I think it is necessary to add create log dir by supervisor instead of by every sub-process, for these logs are written into by supervisor, not by the sub-process. And it is necessary for supervisor to have enough permission to access them. In addition, the log dir of supervisord itself is also need to be created.

@mnaberez
Copy link
Member

No, it's not necessary for supervisord to silently create directories that do not exist. Create the directories before starting supervisord, or before starting the subprocesses. It has worked this way for over a decade and it's been fine, and most other software works this way too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants