Parse env configuration in posix mode #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Supervisor#328 This allows (escaped) quotes in the values as well as empty values.
|
+1 |
|
Supervisor still supports Python 2.5 but the posix mode for shlex was added in 2.6. There has been talk recently about a new major version of Supervisor that would raise the Python requirement to 2.6. If that happens, I would like to merge this. |
mnaberez
added a commit
that referenced
this pull request
Jan 17, 2017
Pull #329 changed shlex to posix mode to fix quotes inside quotes (#328). A side effect of this change is that it broke parsing empty quotes (#873). This seems to be due to a bug in shlex (http://bugs.python.org/issue21999). Since no release version of Supervisor has shipped with shlex in posix mode to support quotes inside quotes, we're reverting it to fix support for empty quotes which has shipped for many Supervisor versions. Two unit tests introduced in #329 pass without posix mode, so those tests have been retained. A unit test was also added for #873 in the previous commit. Reopens #328 Partially reverts #329 Fixes #873 Closes #880
mnaberez
added a commit
that referenced
this pull request
May 27, 2017
Pull #329 changed shlex to posix mode to fix quotes inside quotes (#328). A side effect of this change is that it broke parsing empty quotes (#873). This seems to be due to a bug in shlex (http://bugs.python.org/issue21999). Since no release version of Supervisor has shipped with shlex in posix mode to support quotes inside quotes, we're reverting it to fix support for empty quotes which has shipped for many Supervisor versions. Two unit tests introduced in #329 pass without posix mode, so those tests have been retained. A unit test was also added for #873 in the previous commit. Reopens #328 Partially reverts #329 Fixes #873 Closes #880
|
It looks like Is that not correct? |
vereszol
pushed a commit
to vereszol/supervisor
that referenced
this pull request
Dec 8, 2023
Fixes Supervisor#328 This allows (escaped) quotes in the values as well as empty values. -- This was done in pull request Supervisor#329 but removed as it broke parsing empty quotes (Supervisor#873) due to a bug in shlex (http://bugs.python.org/issue21999). This bug is fixed so posix mode can be used. Brings back Supervisor#329 Partially reverts Supervisor#880
vereszol
pushed a commit
to vereszol/supervisor
that referenced
this pull request
Dec 8, 2023
Fixes Supervisor#328 This allows (escaped) quotes in the values as well as empty values. This was done in pull request Supervisor#329 but removed as it broke parsing empty quotes (Supervisor#873) due to a bug in shlex (http://bugs.python.org/issue21999). This bug is fixed so posix mode can be used. Brings back Supervisor#329 Partially reverts Supervisor#880
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #328
This allows (escaped) quotes in the values as well as empty
values.