Introduce base_path for web interface
#593
Conversation
Implment on existing :class:`supervisor_af_inet_http_server` class, hence :mod:`medusa` module is remained untouched.
calvin
changed the title
base_path for web interface
|
@calvin would you mind clearing up the merge conflicts? I'm keen to use this same feature. |
… into url-prefix-for-web-interface Conflicts: CHANGES.txt
|
@SEJeff resolved the merge conflicts with master branch HEAD. |
| @@ -48,3 +48,5 @@ Contributors | |||
| - Márk Sági-Kazár, 2013-12-16 | |||
|
|
|||
| - Gülşah Köse, 2014-07-17 | |||
|
|
|||
| - Seyeong Jeong, 2016-03-19 | |||
There was a problem hiding this comment.
Do you think it will take a year to accept yor PR?
There was a problem hiding this comment.
Corrected year in commit fdbdaaf.
|
Is there any reason not to use just absolute path? |
|
👍 |
| server_url = form['SERVER_URL'] | ||
| location = server_url + '?message=%s' % urllib.quote( | ||
| message) | ||
| location = '%s?message=%s' % (self.base_path, urllib.quote(message)) |
There was a problem hiding this comment.
This is probably fine but it should be noted that this PR quietly removed SERVER_URL from the redirect.
Fixed incorrect year.
|
It is a base feature to working with reverse proxy without creating useless subdomain, do you think it will take a few more years for this PR to be accepted? |
|
Indeed, this will be merged next year and then we will have to wait 2 more years for version v4 to be launched and get into repos, instead of hotfixing one line of code in v3 (#845) |
|
Any update on this PR? |
This is a pull request to resolve issue #29 and #372.
Instead of relying on
HTTP_REFERERlike in #28, I have introduced a new option.This PR also addresses issue #495 (dup: #251).