Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration file to be specified via a environment variable #917

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luto
Copy link
Contributor

@luto luto commented Apr 9, 2017

Fixes #742

This PR enables the configuration file to be specified in the $SUPERVISOR_CONFIG environment variable. Refer to the issue for further discussion.

Copy link
Member

@mnaberez mnaberez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't merge any new features that don't have tests. Please remove the unrelated gitignore changes.

@luto
Copy link
Contributor Author

luto commented Apr 11, 2017

  1. tests: will do
  2. gitignore: gotcha. See Add a couple of common python dirs to .gitignore #919

@mnaberez
Copy link
Member

Thanks, I've merged #919.

@luto
Copy link
Contributor Author

luto commented Apr 11, 2017

@mnaberez got tests now and they pass in the CI. Please let me know if you need anything else! :)

Copy link
Member

@mnaberez mnaberez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test this locally and if I don't find any issues, I'll merge it for the next feature release.

@luto
Copy link
Contributor Author

luto commented Apr 16, 2017

Thank you! :)

@luto
Copy link
Contributor Author

luto commented Oct 8, 2017

@mnaberez any news on this? :)

@santiagobasulto
Copy link

Hello, I came here searching for this. Any news on when it's planned to be merged/released?

@mjpieters
Copy link
Contributor

I'd have created this very pull request if this wasn't here already. What is the status of this, what is missing (if anything) before this can be merged?

@mnaberez
Copy link
Member

What is the status of this, what is missing (if anything) before this can be merged?

I reviewed it again and it looks fine to me. I intend to include it in the next release.

@delgor
Copy link

delgor commented Oct 6, 2022

Hi, I'd love to see this feature as well. Did anything change since your last review, what is required for this to be merged?

@luto
Copy link
Contributor Author

luto commented Oct 6, 2022

We are still interested as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Allow a configuration file to be determined via ENVIRONMENT vars
5 participants