Skip to content

Commit

Permalink
release-10.12.0 code review changes
Browse files Browse the repository at this point in the history
  • Loading branch information
goldenraphti committed May 16, 2024
1 parent 923c946 commit e23f804
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 6 deletions.
2 changes: 0 additions & 2 deletions RELEASE_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,3 @@
- chore deps (update deps packages minor versions)

- remove Sentry from codebase

## Design System website
14 changes: 14 additions & 0 deletions src/App/ComponentsDocumentation/components/Dialog/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,20 @@ const ExampleOldSyntax = () => (
<h2 id="overview">
Example Old Dialog component - silent support until next major release
</h2>
<p>
We're keeping a silent support for the "now old" Dialog component syntax.
</p>
<p>
We decided to move away in order to use the standard{" "}
<CodeTags type="secondary" code="<dialog>" /> element, and the benefits
its brings along (less scripts needed, better accessibility, etc.).
</p>
<p>
Some updates might be ported to the old syntax, but we recommend migrating
as soon as you can to enjoy all the new shiny updates (e.g. transition on
open/close, etc). Plus, the new syntax is <em>much</em> easier to use. The
support for it will be removed during the next major release.
</p>
<ComponentPreview language="html" showCasePanel codeFigure>
<button
className="btn btn-primary"
Expand Down
8 changes: 4 additions & 4 deletions src/App/Home/constants.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export const changeLogs = [
<p>
<strong>Buttons</strong>
<ul>
<li>icon button for Danish MitId</li>
<li>new icon button for Danish MitId 🇩🇰 🔐</li>
<li>minor non-breaking UI updates (e.g. hover color, ...)</li>
</ul>
</p>
Expand Down Expand Up @@ -54,8 +54,8 @@ export const changeLogs = [
better 🚀. Move to it as soon as you can. Life shines brighter on the
other side 🌻
<br />
We keep silent support for the old dialog syntax (until next major
release).
We keep a silent support for the old dialog syntax until the next
major release.
<br />
The new dialog gets all those UI freebies & options:
<ul>
Expand All @@ -77,7 +77,7 @@ export const changeLogs = [
</p>
<p className="small">
<span className="font-italic">
*Just to be clear. I hate the word "losers". There are no losers in
*Just to be clear, I hate the word "losers". There are no losers in
life, or maybe only the people who think life is a competition. I
just wanted it to be clear
</span>{" "}
Expand Down

0 comments on commit e23f804

Please sign in to comment.