Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 10.8.6 #910

Merged
merged 18 commits into from
Oct 30, 2023
Merged

Release 10.8.6 #910

merged 18 commits into from
Oct 30, 2023

Conversation

goldenraphti
Copy link
Collaborator

Changelog

[10.8.6] - 13.09.2023

Bug Fixes

Component changes

Non breaking UI changes

  • add possibility to disable rotation of the dropdown toggle icon on active state
  • add possibility to style bank-id button as secondary

Testing

  • E2E tests for dropdown component

Design System website

  • expand components preview containers to full screen (only in Topbar component for now)

goldenraphti and others added 17 commits August 25, 2023 13:35
Release 10.8.5
…opdown_icon_rotation

SWED-2266 disable dropdown icon rotation
…_component_preview

feature/SWED-2268 expandable component preview
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.25 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.25...8.4.31)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…css-8.4.31

Bump postcss from 8.4.25 to 8.4.31
…tton_secondary

SWED-2288 bank id button secondary
@mergify
Copy link

mergify bot commented Oct 13, 2023

⚠️ The sha of the head commit of this PR conflicts with #909. Mergify cannot evaluate rules on this PR. ⚠️

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #910 (11e3b47) into master (99d8877) will decrease coverage by 0.29%.
Report is 79 commits behind head on master.
The diff coverage is 33.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #910      +/-   ##
==========================================
- Coverage   72.94%   72.65%   -0.29%     
==========================================
  Files         210      211       +1     
  Lines        4472     4498      +26     
  Branches     1241     1257      +16     
==========================================
+ Hits         3262     3268       +6     
- Misses       1074     1093      +19     
- Partials      136      137       +1     
Files Coverage Δ
...nentsDocumentation/components/Buttons/constants.js 100.00% <ø> (ø)
...entsDocumentation/components/Dropdown/constants.js 31.81% <ø> (ø)
...mponentsDocumentation/components/Dropdown/index.js 61.11% <ø> (ø)
...onentsDocumentation/components/Expandable/index.js 50.00% <ø> (-13.64%) ⬇️
...ComponentsDocumentation/components/Topbar/index.js 50.00% <ø> (ø)
src/App/Home/constants.js 100.00% <ø> (ø)
src/App/routes/components.js 100.00% <ø> (ø)
...tsDocumentation/components/Expandable/constants.js 75.00% <75.00%> (ø)
src/App/components/Expandable/index.js 90.00% <75.00%> (-10.00%) ⬇️
src/App/components/Dropdown/index.js 66.66% <42.85%> (-4.45%) ⬇️
... and 1 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ac85a3...11e3b47. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Oct 13, 2023

Size Change: +2.78 kB (0%)

Total Size: 1.1 MB

Filename Size Change
dist/designguide/styles/documentation-payex.css 8.57 kB +379 B (+5%) 🔍
dist/designguide/styles/documentation-swedbankpay.css 7.67 kB +384 B (+5%) 🔍
dist/designguide/styles/payex.css 41.2 kB +184 B (0%)
dist/designguide/styles/swedbankpay.css 39.2 kB +219 B (+1%)
dist/scripts/payex.js 322 kB +225 B (0%)
dist/scripts/swedbankpay.js 322 kB +226 B (0%)
dist/styles/documentation-payex.css 8.57 kB +379 B (+5%) 🔍
dist/styles/documentation-swedbankpay.css 7.67 kB +384 B (+5%) 🔍
dist/styles/payex.css 41.2 kB +184 B (0%)
dist/styles/swedbankpay.css 39.2 kB +219 B (+1%)
ℹ️ View Unchanged
Filename Size
dist/designguide/scripts/dg-dashboard.js 72.9 kB
dist/designguide/scripts/dg.js 24.5 kB
dist/scripts/9438.js 71.8 kB
dist/scripts/dg-dashboard.js 72.9 kB
dist/scripts/dg.js 24.5 kB

compressed-size-action

@mergify
Copy link

mergify bot commented Oct 16, 2023

⚠️ The sha of the head commit of this PR conflicts with #909. Mergify cannot evaluate rules on this PR. ⚠️

errorMessage,
fullWidth,
position,
noRotation = false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid double negative if you can, it is easier to read rotation = true than rotation is true if noRotation is false.

@mergify
Copy link

mergify bot commented Oct 26, 2023

⚠️ The sha of the head commit of this PR conflicts with #909. Mergify cannot evaluate rules on this PR. ⚠️

Copy link
Collaborator

@stepandersen stepandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@goldenraphti goldenraphti merged commit bd42c84 into master Oct 30, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants