Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pfe-199: Changed color for brand-seconday-hover, btn-active-color and… #940

Merged
merged 7 commits into from
Jan 23, 2024

Conversation

Fastanton
Copy link
Collaborator

… btn-secondary-hover

Description

the colors for brand-secondary-hover, --btn-active-color, --btn-secondary-hover was wrong. And need to change color.

Motivation and Context

The problems is solved with the corrections.

How Has This Been Tested?

Visual review sent to designer.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have updated the CHANGELOG document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Review instructions

Review instructions

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

github-actions bot commented Jan 22, 2024

Size Change: +6 B (0%)

Total Size: 1.12 MB

ℹ️ View Unchanged
Filename Size Change
dist/designguide/scripts/dg-dashboard.js 72.9 kB 0 B
dist/designguide/scripts/dg.js 24.7 kB 0 B
dist/designguide/styles/documentation-payex.css 9.9 kB +4 B (0%)
dist/designguide/styles/documentation-swedbankpay.css 8.98 kB 0 B
dist/designguide/styles/payex.css 44.4 kB -1 B (0%)
dist/designguide/styles/swedbankpay.css 42.3 kB 0 B
dist/scripts/9438.js 71.8 kB 0 B
dist/scripts/dg-dashboard.js 72.9 kB 0 B
dist/scripts/dg.js 24.7 kB 0 B
dist/scripts/payex.js 322 kB 0 B
dist/scripts/swedbankpay.js 322 kB 0 B
dist/styles/documentation-payex.css 9.9 kB +4 B (0%)
dist/styles/documentation-swedbankpay.css 8.98 kB 0 B
dist/styles/payex.css 44.4 kB -1 B (0%)
dist/styles/swedbankpay.css 42.3 kB 0 B

compressed-size-action

@@ -157,7 +157,7 @@ body {
/* TODO: to be converted: --brand-primary-faded: fade(var(--brand-primary, #2A9D3F), 60%); */

--brand-secondary: #3c3c3c;
--brand-secondary-hover: #5f5f5f;
--brand-secondary-hover: #707070;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember to keep "LESS vars" and "Pure CSS vars, i.e. custom properties" in sync 😉

@@ -33,7 +33,7 @@
}

&:active {
border: 1px solid @brand-secondary-info-1;
border: 1px solid @brand-primary;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember to try to use CSS custom properties when possible and when it is not requiring too much work 😉

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (504e9d7) 72.30% compared to head (f2ff86a) 72.30%.
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #940   +/-   ##
========================================
  Coverage    72.30%   72.30%           
========================================
  Files          212      212           
  Lines         4586     4586           
  Branches      1306     1306           
========================================
  Hits          3316     3316           
  Misses        1126     1126           
  Partials       144      144           
Files Coverage Δ
src/App/Home/constants.js 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b148903...f2ff86a. Read the comment docs.

@@ -75,7 +75,7 @@

@btn-secondary-color: @white;
@btn-secondary-bg: @brand-secondary;
@btn-secondary-hover: @brand-primary;
@btn-secondary-hover: #707070;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@btn-secondary-hover: #707070;
@btn-secondary-hover: @soft-brown;

src/less/variables-payex.less Outdated Show resolved Hide resolved
Co-authored-by: Raphael Ferrand <goldenraphti@users.noreply.github.com>
Fastanton and others added 2 commits January 22, 2024 14:57
Co-authored-by: Raphael Ferrand <goldenraphti@users.noreply.github.com>
Co-authored-by: Raphael Ferrand <goldenraphti@users.noreply.github.com>
Copy link
Collaborator

@goldenraphti goldenraphti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approooooved 💫✨💜

Copy link
Collaborator

@Joelhagg Joelhagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! If @goldenraphti give the thumbs up, so do I 👌

@goldenraphti goldenraphti merged commit 5452be3 into develop Jan 23, 2024
8 of 9 checks passed
@github-actions github-actions bot deleted the feature/pfe-199-update-buttons-toolbar-focus branch January 23, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants