-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pfe-199: Changed color for brand-seconday-hover, btn-active-color and… #940
pfe-199: Changed color for brand-seconday-hover, btn-active-color and… #940
Conversation
… btn-secondary-hover
|
Size Change: +6 B (0%) Total Size: 1.12 MB ℹ️ View Unchanged
|
src/less/variables-payex.less
Outdated
@@ -157,7 +157,7 @@ body { | |||
/* TODO: to be converted: --brand-primary-faded: fade(var(--brand-primary, #2A9D3F), 60%); */ | |||
|
|||
--brand-secondary: #3c3c3c; | |||
--brand-secondary-hover: #5f5f5f; | |||
--brand-secondary-hover: #707070; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remember to keep "LESS vars" and "Pure CSS vars, i.e. custom properties" in sync 😉
@@ -33,7 +33,7 @@ | |||
} | |||
|
|||
&:active { | |||
border: 1px solid @brand-secondary-info-1; | |||
border: 1px solid @brand-primary; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remember to try to use CSS custom properties when possible and when it is not requiring too much work 😉
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #940 +/- ##
========================================
Coverage 72.30% 72.30%
========================================
Files 212 212
Lines 4586 4586
Branches 1306 1306
========================================
Hits 3316 3316
Misses 1126 1126
Partials 144 144
Continue to review full report in Codecov by Sentry.
|
src/less/variables-payex.less
Outdated
@@ -75,7 +75,7 @@ | |||
|
|||
@btn-secondary-color: @white; | |||
@btn-secondary-bg: @brand-secondary; | |||
@btn-secondary-hover: @brand-primary; | |||
@btn-secondary-hover: #707070; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@btn-secondary-hover: #707070; | |
@btn-secondary-hover: @soft-brown; |
Co-authored-by: Raphael Ferrand <goldenraphti@users.noreply.github.com>
Co-authored-by: Raphael Ferrand <goldenraphti@users.noreply.github.com>
Co-authored-by: Raphael Ferrand <goldenraphti@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approooooved 💫✨💜
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! If @goldenraphti give the thumbs up, so do I 👌
… btn-secondary-hover
Description
the colors for brand-secondary-hover, --btn-active-color, --btn-secondary-hover was wrong. And need to change color.
Motivation and Context
The problems is solved with the corrections.
How Has This Been Tested?
Visual review sent to designer.
Screenshots (if appropriate):
Types of changes
Checklist:
Review instructions
Review instructions