Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PFE-11: Updated font for skip-link #941

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

Fastanton
Copy link
Collaborator

Description

Skip-link got the wrong font. Should be Futura PT W08 Book.

Changed font for skip-link.

Motivation and Context

It was the wrong font.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have updated the CHANGELOG document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Review instructions

Review instructions

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2ff86a) 72.30% compared to head (00fce5b) 72.30%.
Report is 26 commits behind head on develop.

❗ Current head 00fce5b differs from pull request most recent head c0151fc. Consider uploading reports for the commit c0151fc to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #941   +/-   ##
========================================
  Coverage    72.30%   72.30%           
========================================
  Files          212      212           
  Lines         4586     4586           
  Branches      1306     1306           
========================================
  Hits          3316     3316           
  Misses        1126     1126           
  Partials       144      144           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 091a0a8...c0151fc. Read the comment docs.

Copy link

github-actions bot commented Jan 22, 2024

Size Change: +18 B (0%)

Total Size: 1.12 MB

ℹ️ View Unchanged
Filename Size Change
dist/designguide/scripts/dg-dashboard.js 72.9 kB 0 B
dist/designguide/scripts/dg.js 24.7 kB 0 B
dist/designguide/styles/documentation-payex.css 9.92 kB 0 B
dist/designguide/styles/documentation-swedbankpay.css 8.98 kB 0 B
dist/designguide/styles/payex.css 44.6 kB +9 B (0%)
dist/designguide/styles/swedbankpay.css 42.3 kB 0 B
dist/scripts/9438.js 71.8 kB 0 B
dist/scripts/dg-dashboard.js 72.9 kB 0 B
dist/scripts/dg.js 24.7 kB 0 B
dist/scripts/payex.js 322 kB 0 B
dist/scripts/swedbankpay.js 322 kB 0 B
dist/styles/documentation-payex.css 9.92 kB 0 B
dist/styles/documentation-swedbankpay.css 8.98 kB 0 B
dist/styles/payex.css 44.6 kB +9 B (0%)
dist/styles/swedbankpay.css 42.3 kB 0 B

compressed-size-action

goldenraphti
goldenraphti previously approved these changes Jan 22, 2024
@goldenraphti goldenraphti merged commit 3d0cad9 into develop Jan 23, 2024
7 of 8 checks passed
@github-actions github-actions bot deleted the feature/pfe-11-update-skip-link-component branch January 23, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants