Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWED-2444 fix dead links get started pages #948

Merged

Conversation

goldenraphti
Copy link
Collaborator

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have updated the CHANGELOG document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Review instructions

Review instructions

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (60ae86f) 72.41% compared to head (88d6320) 72.41%.
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #948   +/-   ##
========================================
  Coverage    72.41%   72.41%           
========================================
  Files          212      212           
  Lines         4604     4604           
  Branches      1309     1309           
========================================
  Hits          3334     3334           
  Misses        1126     1126           
  Partials       144      144           
Files Coverage Δ
...c/App/GetStarted/get-started/ForDesigners/index.js 45.45% <ø> (ø)
.../GetStarted/get-started/ForDevelopers/constants.js 100.00% <100.00%> (ø)
.../App/GetStarted/get-started/ForDevelopers/index.js 86.11% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7e3e63...88d6320. Read the comment docs.

Copy link

github-actions bot commented Feb 1, 2024

Size Change: 0 B

Total Size: 1.13 MB

ℹ️ View Unchanged
Filename Size
dist/designguide/scripts/dg-dashboard.js 72.9 kB
dist/designguide/scripts/dg.js 24.7 kB
dist/designguide/styles/documentation-payex.css 9.96 kB
dist/designguide/styles/documentation-swedbankpay.css 9.02 kB
dist/designguide/styles/payex.css 47.3 kB
dist/designguide/styles/swedbankpay.css 44.9 kB
dist/scripts/9438.js 71.8 kB
dist/scripts/dg-dashboard.js 72.9 kB
dist/scripts/dg.js 24.7 kB
dist/scripts/payex.js 322 kB
dist/scripts/swedbankpay.js 322 kB
dist/styles/documentation-payex.css 9.96 kB
dist/styles/documentation-swedbankpay.css 9.02 kB
dist/styles/payex.css 47.3 kB
dist/styles/swedbankpay.css 44.9 kB

compressed-size-action

@goldenraphti goldenraphti merged commit 812f671 into develop Feb 1, 2024
8 of 9 checks passed
@github-actions github-actions bot deleted the feature/SWED-2444-bugfix_dead_links_get_started_pages branch February 1, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant