Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruction checks: non-universal assertions should be generated based on instruction type #49

Open
silabs-mateilga opened this issue May 21, 2021 · 0 comments

Comments

@silabs-mateilga
Copy link

When running formal verification of an instruction on a risc-v core, not all assertions in the rvfi_insn_check.sv file are relevant, and can cause a lot of noise in the form of unmet related covers. A good example of this is rs2-related assertions when checking a I-type instruction, as there is no rs2-field, the preconditions can not be met, which shows as an error in the formal verification run.

I propose that these assertions are filtered by ifdef/generate based on instruction type, so the assertion only gets generated if the assertion is relevant for the instruction that is being checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant