Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show how long until you can request another reset e-mail #180

Open
joao66br opened this issue Jul 25, 2021 · 1 comment
Open

Show how long until you can request another reset e-mail #180

joao66br opened this issue Jul 25, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@joao66br
Copy link

Hi,
Instead of the message 'try again soon', it would be better, 'you can request another email in x minutes',

Thanks,

@jrushlow jrushlow added the enhancement New feature or request label Jul 30, 2021
@jrushlow
Copy link
Collaborator

Howdy @joao66br - are you referring the TooManyPasswordRequestsException::class?

return 'You have already requested a reset password email. Please check your email or try again soon.';

My knee jerk reaction is to say that because this message is coming from an Exception object, the object itself should be dead simple without needing to rely on other components (e.g. translations) to properly function. If we formatted the message from getReason() to include some sort of interval, e.g. 1 hour, we would need to provide translation support for that interval.

I'm not completely for doing this by default, but I'm open to the idea of making this optional as I can definitely see where the end user is sitting there like "How soon?..." I would think doing something like getReason(DateInterval $retryIn = null) would be what we are looking for..

PR's welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants