Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Inkwhale Token #25

Merged
merged 6 commits into from
Jul 27, 2024
Merged

Verify Inkwhale Token #25

merged 6 commits into from
Jul 27, 2024

Conversation

Albert-Tran
Copy link
Contributor

@Albert-Tran Albert-Tran commented Jul 4, 2024

ASCAN Token Submission

Introduction

Before submitting this PR, ensure you have followed all the requirements below and filled out all necessary details about your token.

Checklist

Please review the checklist below and check each item before submitting your token information:

  • I have reviewed the submission guidelines.
  • The submitted files are in the correct format and fulfill all requirements outlined below.

Asset Details

General Information

  • Token Name:
  • Symbol:
  • Contract Address:
  • Decimals:

Logo

  • Logo file added to the PR
  • File Name: logo.png
  • Size: 256x256 pixels
  • File Extension: png

Metadata File

  • Metadata file added to the PR
  • File Name: metadata.json
  • File Extension: json

Token Information File

  • Token information file added to the PR
  • File Name: info.json
  • File Extension: json

Required Content in info.json:

{
  "name": "",
  "symbol": "",
  "type": "PSP22",
  "contractAddress": "",
  "decimals": 12,
  "description": "",
  "website": "",
  "sourceCode": "https://github.com/{Github_Username}/{Repository_Name}/path/to/contract",
  "links": [
    {
      "name": "X/Twitter",
      "url": ""
    },
    {
      "name": "Telegram",
      "url": ""
    },
    {
      "name": "Discord",
      "url": ""
    }
  ],
  "customTags": [
    "burnerWallet",
    "otherTag"
  ],
  "warnings": [],
  "owner": "ownerAddress",
  "minter": "minterAddress"
}

Note on Custom Tags

The customTags field in the info.json file is optional. This field can be used to include specific tags that describe unique characteristics or features of the token, such as burner wallet. Include custom tags only if they are relevant to the token’s functionality or usage.

Note on Owner and Minter

The owner and minter fields should include the addresses of the accounts that hold these capabilities within the token's smart contract. The owner is typically the account that has administrative rights over the entire contract, while the minter might be an account with the capability to issue new tokens.

Note on Warnings

Please do not fill out the warnings field in the info.json file. This field is reserved for use by our auditing team, who will add relevant warnings such as "Mintable" or "Burnable" after thoroughly reviewing the token's smart contract. This ensures that all warnings are accurate and based on a comprehensive technical assessment.

@piotrszacilowski piotrszacilowski self-requested a review July 15, 2024 19:21
Copy link
Member

@piotrszacilowski piotrszacilowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. You could do a rebase to main?
I can't do that due to the fact that your branch is a fork.
Also check out the guidelines. And fill out the pull request description.

@Albert-Tran
Copy link
Contributor Author

Hi @piotrszacilowski , i followed the https://github.com/SyncraDAO/psp-tokenlist?tab=readme-ov-file#how-to-submit-token-information-via-github. After creating a pull request, i always make a fork version from https://github.com/SyncraDAO
Can we make a meeting to support me?

@DamianStraszak
Copy link
Collaborator

Thank you for the submission. Everything seems to be correct.

The info.json template has also a minter field which you didn't fill. Since the owner has minting rights, you can just put the owner address there.

@Albert-Tran
Copy link
Contributor Author

Hi @DamianStraszak could u pls my pr again? thank u so much

Copy link
Collaborator

@DamianStraszak DamianStraszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Albert-Tran
Copy link
Contributor Author

Hi @Kodziak , could u pls review my pr ? I see u were requested to review. Thank u so much

@Kodziak Kodziak merged commit 614b93e into SyncraDAO:main Jul 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants