Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5G1LVy9K5uapJE9uzG1NbMN4bTKJEyKLMtKGAtqdgbLDegNF #75

Merged
merged 8 commits into from
Aug 17, 2024

Conversation

stakingluke
Copy link
Contributor

@stakingluke stakingluke commented Aug 10, 2024

ASCAN Token Submission

Introduction

Before submitting this PR, ensure you have followed all the requirements below and filled out all necessary details about your token.

Checklist

Please review the checklist below and check each item before submitting your token information:

  • I have reviewed the submission guidelines.
  • The submitted files are in the correct format and fulfill all requirements outlined below.

Asset Details

General Information

  • Token Name:
  • Symbol:
  • Contract Address:
  • Decimals:

Logo

  • Logo file added to the PR
  • File Name: logo.png
  • Size: 256x256 pixels
  • File Extension: png

Metadata File

  • Metadata file added to the PR
  • File Name: metadata.json
  • File Extension: json

Token Information File

  • Token information file added to the PR
  • File Name: info.json
  • File Extension: json

Required Content in info.json:

{
  "name": "",
  "symbol": "",
  "type": "PSP22",
  "contractAddress": "",
  "decimals": 12,
  "description": "",
  "website": "",
  "sourceCode": "https://github.com/{Github_Username}/{Repository_Name}/path/to/contract",
  "links": [
    {
      "name": "X/Twitter",
      "url": ""
    },
    {
      "name": "Telegram",
      "url": ""
    },
    {
      "name": "Discord",
      "url": ""
    }
  ],
  "customTags": [
    "burnerWallet",
    "otherTag"
  ],
  "warnings": [],
  "owner": "ownerAddress",
  "minter": "minterAddress"
}

Note on Custom Tags

The customTags field in the info.json file is optional. This field can be used to include specific tags that describe unique characteristics or features of the token, such as burner wallet. Include custom tags only if they are relevant to the token’s functionality or usage.

Note on Owner and Minter

The owner and minter fields should include the addresses of the accounts that hold these capabilities within the token's smart contract. The owner is typically the account that has administrative rights over the entire contract, while the minter might be an account with the capability to issue new tokens.

Note on Warnings

Please do not fill out the warnings field in the info.json file. This field is reserved for use by our auditing team, who will add relevant warnings such as "Mintable" or "Burnable" after thoroughly reviewing the token's smart contract. This ensures that all warnings are accurate and based on a comprehensive technical assessment.

@Kodziak
Copy link
Contributor

Kodziak commented Aug 13, 2024

Hey, the PR appears to be empty. Haven't you forgotten to attach the files?

@stakingluke
Copy link
Contributor Author

stakingluke commented Aug 13, 2024 via email

@stakingluke
Copy link
Contributor Author

stakingluke commented Aug 13, 2024 via email

@stakingluke
Copy link
Contributor Author

where can i find the metadata from my token? i create it on inkwhale

@stakingluke
Copy link
Contributor Author

okay metadata are ready and uploaded

@stakingluke
Copy link
Contributor Author

Pleas check if it is ok

@Kodziak
Copy link
Contributor

Kodziak commented Aug 14, 2024

You're missing the link to the source code. I believe if it's InkWhale, it should be this one:

https://github.com/InkWhale-net/contracts/blob/feature/upgrade-op-4/contracts/psp22_standard/lib.rs

What's more:

  1. Your wallet owns the smart contract, as the address should be filled in the “owner” field: 5Gp7WEKbbmGEDqodxTWLUfuY48au1MP81B29Rjtrp9s1yThn

@Kodziak
Copy link
Contributor

Kodziak commented Aug 14, 2024

Sorry, my bad. Please fill also the minter field with the same value as the owner. Then we're good to go.

Copy link
Contributor Author

@stakingluke stakingluke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@ggawryal ggawryal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source code address is slightly wrong, but otherwise LGTM

5G1LVy9K5uapJE9uzG1NbMN4bTKJEyKLMtKGAtqdgbLDegNF Outdated Show resolved Hide resolved
Co-authored-by: Grzegorz Gawryał <31205678+ggawryal@users.noreply.github.com>
@stakingluke
Copy link
Contributor Author

okay, done. please check :) when will the token be verified? Thanks.

@Kodziak Kodziak merged commit 9687112 into SyncraDAO:main Aug 17, 2024
@stakingluke stakingluke deleted the patch-4 branch August 17, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants