Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hard-coded MUD School area update rules #182

Open
Synival opened this issue Mar 9, 2020 · 0 comments
Open

Replace hard-coded MUD School area update rules #182

Synival opened this issue Mar 9, 2020 · 0 comments
Labels
rewrite The existing behavior or code is dumb. It should be rewritten while producing the same result.

Comments

@Synival
Copy link
Owner

Synival commented Mar 9, 2020

(After #181)

We should replace the special logic used for refreshing the MUD School with specific area update parameters. In the JSON file, the rules should be:

"always_reset_age": 3,
"active_reset_age": 3

When loading areas, the MUD School should be detected, and the following values should be set:

if (some_check_for_mud_school (new_area)) {
    new_area->always_reset_age = 3;
    new_area->active_reset_age = 3;
}

(This is so we can keep the vanilla MUD School .are file while making the area update logic nice and consistent :D)

@Synival Synival added fix A problem exists that doesn't cause incorrect behavior but still needs to be examined minor feature A built-in feature that doesn't change much of the game's implementation rewrite The existing behavior or code is dumb. It should be rewritten while producing the same result. and removed fix A problem exists that doesn't cause incorrect behavior but still needs to be examined minor feature A built-in feature that doesn't change much of the game's implementation labels Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rewrite The existing behavior or code is dumb. It should be rewritten while producing the same result.
Projects
None yet
Development

No branches or pull requests

1 participant