feature: Replace all Ok. messages with useful messages #46 #178

rhoxie21 · 2020-03-01T23:31:19Z

Addressing issue #46 and had also made one small change to wizhelp; let me know if you want me to take that out...

blakepell · 2020-03-04T14:57:36Z

I have one comment/thought on a few of these (apologies if I ramble). Some of the spells like detect invis generally can only be cast on yourself, however they had code in them that would seem to support a case where they were changed to be cast on others. Here's a snippet and below my comment:

printf_to_char(victim, "Your eyes tingle.\n\r");
    
if (ch != victim)
{
	printf_to_char(ch, "%s's eyes begin to glow.\n\r.", victim->name);
}

In the above, the victim is generally the character but then there's the extra block for if the target of the spell was ever opened to be able to cast on others. printf_to_char using the victims name directly could 'out' the victim if they're cloaked because it always shows their name. Using an ACT function or whatever the equivalent in this version would fix that.

Imagine a player who might be cloaked as a vampire or put a mask on as a swashbuckler where you wouldn't see "Blake is here" but rather "A swashbuckler is here.". The act message would take care of these scenarios (the old function/macro that used to handle this was PERS, I'd have to lookup what it is here).

An example of where a printf with the ch->name could go wrong:

If an immortal is Wizi in the room and cast a spell you would see "Blake utters the words 'detect invis'" instead of "(An Imm) utters the words 'detect invis'".

This isn't so much an issue on immortal commands.

blakepell · 2020-03-04T18:59:09Z

Here's an example with printf's from this pull request I just put in, the immortal sees the person no matter what but the player will see an item taken by whatever PERS_AW returns (that could be the imms name, or if they're wizi (An Imm)):

    printf_to_char(ch, "You have confiscated %s from %s.\r\n", obj->short_descr, victim->name);
    printf_to_char(victim, "%s has confiscated %s from you.\r\n", PERS_AW(ch, victim), obj->short_descr);

Thumbs up on the "wizhelp" changes also. Being able to see the level of the commands are highly useful.

Synival · 2020-03-04T21:21:44Z

@rhoxie21 @blakepell Just a heads up, work & home life is keeping me extremely busy this week, so I'll have to review all of these contributions more seriously this weekend - I'll just drop some quick comments before I go to bed...

By the way, a VERY LARGE update is in the works that I want to release this weekend. It's taken a while because a lot of the database loading has been effected, so there's been a lot to test. Many, many cool things are coming soon :D Well, at least I think they're cool ;)

Synival · 2020-03-04T21:23:47Z

@rhoxie21 Thanks for taking care of the wiz commands issue, I'll merge it this weekend. I like that change to wizhelp, I vote we toss it in.

Synival · 2020-03-04T21:29:33Z

@blakepell

I have one comment/thought on a few of these (apologies if I ramble). Some of the spells like detect invis generally can only be cast on yourself, however they had code in them that would seem to support a case where they were changed to be cast on others.

Hmm, that's an interesting case. One of the original goals of the project was to keep the gameplay as vanilla as possible, but maybe this could be a compilation flag, or at least something more easily configurable. I've seen other spells like "word of recall" that have the same case (seriously, why would you ever use this spell?).

Imagine a player who might be cloaked as a vampire or put a mask on as a swashbuckler where you wouldn't see "Blake is here" but rather "A swashbuckler is here.". The act message would take care of these scenarios (the old function/macro that used to handle this was PERS, I'd have to lookup what it is here).

Good call - I just created an issue to address this: #179

Thumbs up on the "wizhelp" changes also. Being able to see the level of the commands are highly useful.

Agree! :)

rhoxie21 · 2020-03-05T02:51:56Z

Good stuff, thanks for the comments; updated to act so the context is handled when the player maybe cloaked, etc...

blakepell · 2020-03-05T04:58:11Z

Looks great @rhoxie21. :)

rhoxie21 · 2020-03-06T00:27:45Z

@blakepell - Thanks! What next? :P

Synival · 2020-03-08T16:04:45Z

src/wiz_im.c

@@ -55,13 +55,13 @@ DEFINE_DO_FUN (do_wizhelp) {
        if (cmd_table[cmd].level >= LEVEL_HERO &&
            cmd_table[cmd].level <= char_get_trust (ch) && cmd_table[cmd].show)
        {
-            printf_to_char (ch, "%-12s", cmd_table[cmd].name);
+            printf_to_char(ch, "(%2d) %-12s", cmd_table[cmd].level, cmd_table[cmd].name);
            if (++col % 6 == 0)


@rhoxie21 If we have the wiz levels levels in here, I think the number of commands per line will need to be reduced to fit an 80-column terminal. Everything else still fits in 80 columns, so I think it should be a rule.

This looks good to me:

Reduce command space from 12 chars to 11

Show 5 commands per row instead of 6

Synival · 2020-03-08T16:06:23Z

src/wiz_l1.c

    wiznetf (ch, NULL, WIZ_PENALTIES, WIZ_SECURE, 0,
        "$N denies access to %s", victim->name);
-    send_to_char ("Ok.\n\r", ch);
+    printf_to_char(ch, "$s has been denied and will be escorted out.\n\r", victim->name);


Typo: should be "%s", not "$s"

@Synival - ugh! Resolved this and validated.

<20hp 100m 100mv> Test has been denied and will be escorted out.
Test has left the game.

Synival · 2020-03-08T16:12:52Z

src/wiz_l3.c

@@ -55,7 +55,7 @@ DEFINE_DO_FUN (do_disconnect) {
        for (d = descriptor_list; d != NULL; d = d->next) {
            if (d->descriptor == desc) {
                close_socket (d);
-                send_to_char ("Ok.\n\r", ch);
+                printf_to_char(ch, "%s has been disconnected.\n\r", d->descriptor);


This currently crashes D: "%s" is for a string, d->descriptor is of type sh_int. Something like this would work:

printf_to_char (ch, "Connection #%d has been disconnected.\n\r", d->descriptor); // Connection #8 has been disconnected.

Synival · 2020-03-08T16:14:29Z

src/wiz_l4.c

@@ -359,7 +359,7 @@ DEFINE_DO_FUN (do_oload) {
        obj_give_to_char (obj, ch);
    else
        obj_give_to_room (obj, ch->in_room);
-    send_to_char ("Ok.\n\r", ch);
+    printf_to_char(ch, "You created %p!\n\r", obj); 


<1010hp 1000m 1000mv> load obj 3001 You created 0x7f3ccc236d70!

We can probably use an object name here instead ;)

Resorted to using obj->short_desc

<20hp 100m 100mv> You created a bottle of beer!

Synival · 2020-03-08T16:19:06Z

@rhoxie21 I found a few bugs in your changes but everything is otherwise good 👍 As soon as those are patched, I'll merge the PR :)

rhoxie21 · 2020-03-10T01:40:19Z

@Synival - corrected the items; I will be more thorough in my validation post change. Setting up docker with a few more player files so I can test a bit quicker.

Synival · 2020-03-13T18:22:52Z

@rhoxie21 Looks good :) Merging pull request!

feature: Replace all Ok. messages with useful messages Synival#46

5536662

feat: correct context to act

f5cc39b

Synival reviewed Mar 8, 2020

View reviewed changes

rhoxie21 added 2 commits March 9, 2020 20:23

feat: remove oks and adjust wizh

6d66a9d

feat: fix bugs in PR

2012fcc

Synival merged commit ea0d104 into Synival:unstable Mar 13, 2020

rhoxie21 deleted the remove_ok branch March 28, 2020 19:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: Replace all Ok. messages with useful messages #46 #178

feature: Replace all Ok. messages with useful messages #46 #178

rhoxie21 commented Mar 1, 2020

blakepell commented Mar 4, 2020 •

edited

Loading

blakepell commented Mar 4, 2020 •

edited

Loading

Synival commented Mar 4, 2020

Synival commented Mar 4, 2020

Synival commented Mar 4, 2020

rhoxie21 commented Mar 5, 2020

blakepell commented Mar 5, 2020

rhoxie21 commented Mar 6, 2020

Synival Mar 8, 2020

rhoxie21 Mar 10, 2020

Synival Mar 8, 2020

rhoxie21 Mar 10, 2020

Synival Mar 8, 2020

rhoxie21 Mar 10, 2020

Synival Mar 8, 2020

rhoxie21 Mar 10, 2020

Synival commented Mar 8, 2020

rhoxie21 commented Mar 10, 2020

Synival commented Mar 13, 2020

feature: Replace all Ok. messages with useful messages #46 #178

feature: Replace all Ok. messages with useful messages #46 #178

Conversation

rhoxie21 commented Mar 1, 2020

blakepell commented Mar 4, 2020 • edited Loading

blakepell commented Mar 4, 2020 • edited Loading

Synival commented Mar 4, 2020

Synival commented Mar 4, 2020

Synival commented Mar 4, 2020

rhoxie21 commented Mar 5, 2020

blakepell commented Mar 5, 2020

rhoxie21 commented Mar 6, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Synival commented Mar 8, 2020

rhoxie21 commented Mar 10, 2020

Synival commented Mar 13, 2020

blakepell commented Mar 4, 2020 •

edited

Loading

blakepell commented Mar 4, 2020 •

edited

Loading