Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: Better Card Image for Banner #252

Closed
Ansub opened this issue Jul 6, 2024 · 4 comments
Closed

[FEATURE]: Better Card Image for Banner #252

Ansub opened this issue Jul 6, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@Ansub
Copy link
Member

Ansub commented Jul 6, 2024

Feature Description 📝

The banner card currently uses a placeholder div component labeled "banner." This can be replaced with an image, as done for other components.

Screenshots 📸

CleanShot 2024-07-06 at 14 08 52@2x
@github-actions github-actions bot added the enhancement New feature or request label Jul 6, 2024
@siddhant-agrawal01
Copy link
Contributor

Can you provide the link to this component? I didn't find it

@Ansub
Copy link
Member Author

Ansub commented Jul 14, 2024

https://syntaxui.com/blocks/banner

@Dharsan15
Copy link

Dharsan15 commented Jul 16, 2024 •
edited
Loading

But the banner component doesn't look like the screenshot i think it is already updated and what kind of enhancement should we make for the banner component

@Ansub
Copy link
Member Author

Ansub commented Jul 16, 2024

Yeah, I have added that.

Closing this issue.

@Ansub Ansub closed this as completed Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Ansub @Dharsan15 @siddhant-agrawal01