Skip to content

Commit

Permalink
Update sip-378.md
Browse files Browse the repository at this point in the history
  • Loading branch information
kaleb-keny committed Apr 19, 2024
1 parent 2309a85 commit 65b0a7a
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion content/sips/sip-378.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ A) Drop the `acceptablePrice` check on order commitment

B) Use the on-chain price, without any staleness tolerance check, when `settleOrder` calls `requiredCredit`

C)
C) Allow for 0 fee perp trading

## Abstract

Expand All @@ -30,6 +30,9 @@ A) [`acceptablePriceExceeded`](https://github.com/Synthetixio/synthetix-v3/blob/

B) [SIP-354](https://sips.synthetix.io/sips/sip-354) introduced a requirement that all markets, in a given supermarket, are not in a stale state, upon order settlement. This cause issues, given that keepers are compensated for updating 1 price per order. Furthermore, when a user commits to an order, staleness is only checked against the position being altered. This SIP proposes to drop tolerance check requirements when [settleOrder](https://github.com/Synthetixio/synthetix-v3/blob/434b685c49db22ddc24cffa07a6b3fbfb8f0df17/markets/perps-market/contracts/modules/AsyncOrderSettlementPythModule.sol#L46) calls [requiredCredit](https://github.com/Synthetixio/synthetix-v3/blob/9b410c97cc1afee9c0c0c4ced5a1e652369bf36f/markets/perps-market/contracts/storage/PerpsMarket.sol#L431C77-L431C86). Note that all other calls to the `requiredCredit` function remain the same with respect to staleness tolerance.


C) Currently the perp markets do no support 0 fee trading if a referrer is set up. This is addressed in this [PR](https://github.com/Synthetixio/synthetix-v3/pull/2110) which results in zero'ing out referrer fees in the situation where the the trader fee is set to zero.

## Motivation

<!--The motivation is critical for SCCPs that want to update variables within Synthetix. It should clearly explain why the existing variable is not incentive aligned. SCCP submissions without sufficient motivation may be rejected outright.-->
Expand Down

0 comments on commit 65b0a7a

Please sign in to comment.