From ba47df9fd5a6e99208e70dc6abd05b7392a2aca5 Mon Sep 17 00:00:00 2001 From: kaleb Date: Wed, 5 Jun 2024 17:07:24 +0200 Subject: [PATCH] Update sip-390.md --- content/sips/sip-390.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/content/sips/sip-390.md b/content/sips/sip-390.md index 1d20b51e1..f3cc17ce4 100644 --- a/content/sips/sip-390.md +++ b/content/sips/sip-390.md @@ -14,17 +14,17 @@ created: 2024-06-05 -This sip proposes to incorporate into the minimum credit calculation the amount of `snxUSD` margin deposited into a given market by traders. +This sip proposes to incorporate into the minimum credit calculation the amount of snxUSD margin deposited into a given market by traders. ## Abstract Some concepts covering this SIP: -- Credit capacity represents the total amount of USD that the market could withdraw if it were to immediately unwrap all its positions. -- Locked credit represents the minimum amount of delegated collateral that needs to be available to allows traders to withdraw their deposited margin and profits. +- Credit capacity represents the total amount of snxUSD that the market could withdraw if it were to immediately unwrap all its positions. +- Locked credit represents the minimum amount of delegated collateral that needs to be credited to a given market, in order to allows traders to withdraw from a given market. -The validation done in the [core of the system](https://github.com/Synthetixio/synthetix-v3/blob/cace699d1fb070042ca09a390c95548c31a5d025/protocol/synthetix/contracts/storage/Market.sol#L277) uses these concepts whereby `creditCapacityD18` is calculated by summing up the value of the delegated collateral of LP's **but also includes traders margin**. However, `lockedCredit` does not include the latter margin, resulting in the validation not covering the edge case where markets are not covered by enough collateral to cover traders' margin. +The validation done in the [core of the system](https://github.com/Synthetixio/synthetix-v3/blob/cace699d1fb070042ca09a390c95548c31a5d025/protocol/synthetix/contracts/storage/Market.sol#L277) uses these concepts whereby `creditCapacityD18` is calculated by summing up the value of the delegated collateral of LP's **but also includes traders margin**. However, `lockedCredit` does not include the latter margin amount, hence this sip. Currently, minimum credit is calculated by iterating on over active markets, getting the active open interest and multiplying that by a `lockedOiRatio`, this gives insight information on the expected credit that needs to be catered for by LP's. ## Motivation @@ -37,7 +37,7 @@ The minimum credit calculation update ensures that markets are sufficiently cove -The original [validation](https://github.com/Synthetixio/synthetix-v3/blob/cace699d1fb070042ca09a390c95548c31a5d025/protocol/synthetix/contracts/storage/Market.sol#L278) did not take into account that traders' margin are included credit capacity. This patch only needs to be applied to, `snxUSD`, while other spot synths, deposited by traders are **not** included into `creditCapacity` calculation by the core system. +The original [validation](https://github.com/Synthetixio/synthetix-v3/blob/cace699d1fb070042ca09a390c95548c31a5d025/protocol/synthetix/contracts/storage/Market.sol#L278) did not take into account that traders' margin are included credit capacity. This patch only needs to be applied to, snxUSD, while other spot synths, deposited by traders are **not** included into `creditCapacity` calculation by the core system by default. ## Technical Specification