Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIP-330 Minimum collateral capacity view function and event #1613

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

noisekit
Copy link
Contributor

When opening a pull request to submit a new SIP, please use the suggested template: https://github.com/Synthetixio/SIPs/blob/master/sip-X.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing Draft PRs.
  • The build passes.
  • Your Github username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@noisekit noisekit self-assigned this Jun 28, 2023
@vercel
Copy link

vercel bot commented Jun 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sips ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2023 9:22am

@noisekit noisekit changed the title SIP-330: Minimum collateral capacity view function and event SIP-330 Minimum collateral capacity view function and event Aug 7, 2023
@noisekit noisekit marked this pull request as ready for review August 7, 2023 03:04
@kaleb-keny
Copy link
Member

hey @noisekit is this ready for merging?

@noisekit
Copy link
Contributor Author

noisekit commented Aug 9, 2023

After some discussions this does not seem to provide enough value to justify implementation effort. Closing for now.

@noisekit noisekit closed this Aug 9, 2023
@noisekit noisekit deleted the sip-330 branch August 9, 2023 02:58
@kaleb-keny
Copy link
Member

kaleb-keny commented Aug 9, 2023

rip on that orpahned' sip number

@kaleb-keny
Copy link
Member

kaleb-keny commented Aug 9, 2023

could you please reopen, i'll merge it, set status to Rejected

@noisekit noisekit restored the sip-330 branch August 9, 2023 06:45
@noisekit noisekit reopened this Aug 9, 2023
@kaleb-keny
Copy link
Member

hey @noisekit can you please update the status to Rejected

@noisekit
Copy link
Contributor Author

Done @kaleb-keny

@kaleb-keny kaleb-keny merged commit 02055cd into Synthetixio:master Aug 14, 2023
2 checks passed
@noisekit noisekit deleted the sip-330 branch October 5, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants