From f0defbc63e14c69c6962eee1b7142860bfc7c885 Mon Sep 17 00:00:00 2001 From: Noah Litvin <335975+noahlitvin@users.noreply.github.com> Date: Tue, 26 Mar 2024 14:32:33 -0400 Subject: [PATCH] SIP-369 --- content/sips/sip-369.md | 59 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 59 insertions(+) create mode 100644 content/sips/sip-369.md diff --git a/content/sips/sip-369.md b/content/sips/sip-369.md new file mode 100644 index 000000000..543017521 --- /dev/null +++ b/content/sips/sip-369.md @@ -0,0 +1,59 @@ +--- +sip: 369 +title: Remove Maximum Rewards Distributors Limit +network: Ethereum, Optimism & Base +status: Draft +type: Governance +author: 'Noah Litvin (@noahlitvin)' +created: 2024-03-26 +--- + + + +## Simple Summary + + + +This SIP proposes to remove the maximum rewards distributions limit in the rewards manager module, originally implemented with [SIP-305](https://sips.synthetix.io/sips/sip-305/). + +## Abstract + + + +Currently, a pool owner may only register a maximum of 10 rewards distributors per pool. This change entails simply removing this limit. + +## Motivation + + + +This check was originally added as safety mechanism, to prevent a pool owner from registering so many rewards distributors that the `removeRewardsDistributor` function call would fail due to requiring too much gas to execute. + +The decision to set this at 10 was effectively arbitrary and, as more use cases are being explored for rewards distributors (such as distributing liquidated margin collateral from markets), exceeding 10 distributors seems like an increasingly realistic scenario. + +## Rationale + + + +Especially as Synthetix is primarily being deployed on gas-efficient blockchains, this check is now seen as less crucial. Pool owners can be expected to take responsibility for avoiding adding so many rewards distributors to their pool such that there are negative consequences related to gas usage. + +## Technical Specification + + + +Remove `_MAX_REWARD_DISTRIBUTIONS` and the check that relies on this value from `RewardsManagerModule.sol` in the core system. + +### Test Cases + + + +A test could demonstrate that 11 different rewards distributors can be added and then removed from a pool. + +### Configurable Values (Via SCCP) + + + +N/A + +## Copyright + +Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/).